Opened 13 years ago
Closed 11 years ago
#9063 closed enhancement (fixed)
Allow excluding realms from queries by default
Reported by: | anonymous | Owned by: | Steffen Hoffmann |
---|---|---|---|
Priority: | normal | Component: | TagsPlugin |
Severity: | normal | Keywords: | configuration query realms |
Cc: | Itamar Oren | Trac Release: | 0.11 |
Description
I would like to have a config-option that allows excluding, e.g., the ticket realm from tag-queries, such that only if I explicitly include it in the query it will be included.
The patch in #9059 implements this feature using a exclude_realms
list-option.
Attachments (0)
Change History (5)
comment:1 Changed 13 years ago by
Cc: | Itamar Oren added; anonymous removed |
---|---|
Keywords: | configuration query realms added |
Status: | new → assigned |
comment:2 Changed 13 years ago by
Ok, found another way, that doesn't depend on the number of arguments in the current request. :-)
comment:3 Changed 13 years ago by
(In [10661]) TagsPlugin: Provide configurable default list of realms to exclude from tags query, refs #9059 and #9063.
Administrators may configure tag realms to require explicite selection for
every new tags query by adding them to a new ListOption
'exclude_realms'
or 'listtagged_exclude_realms' for ListTagged
macro calls respectively.
The original suggestion has been contributed by Itamar Ostricher, thank you.
These changes include an additional workaround to get the expected result, even if you deselect all available realms. Otherwise this would have neutralized your setting for these options.
comment:4 Changed 12 years ago by
(In [12391]) TagsPlugin: Make realm configuration for ListTagged
more effective, refs #7857 and #9063.
Settings for 'listtagged_exclude_realms' had no effect without a query. Itamar Ostricher discovered this issue in the initial implementation of the feature and suggested this change. Thanks for taking care.
Additionally the broken 'test_empty_content' test in
tractags.tests.macros.ListTaggedMacroTestCase
is fixed, and a regression test
for the pending 'empty query' issue (#7857) has been introduced as well.
Understand, but your proposed solution is flawed, because it does rely on argument counts, that some plugins are known to mess around with. I.e. my local FlexibleWikiPlugin install adds a 'node' argument everywhere, even outside the wiki domain/realm.
May it be, that this is a bug, but I'm reluctant to let it hit TagsPlugin for new stuff. I'm about to alter the implementation to be little more robust against this type of disturbance.