Opened 15 years ago
Closed 11 years ago
#5523 closed defect (fixed)
tags retain punctuation at beginning and end.
Reported by: | Owned by: | Steffen Hoffmann | |
---|---|---|---|
Priority: | normal | Component: | TagsPlugin |
Severity: | normal | Keywords: | tag validation strip |
Cc: | Trac Release: | 0.11 |
Description
It seems that the plugin only splits text with white space. So, the text "word" and "word," are treated differently.
This becomes apparent if I include the summary in the choice of words.
I think punctuation (,;.:-_'") at the beginning and end of a word needs to be stripped away. I do not think it should be removed inside a word. But I cannot see that it is a meaningful part of a tag at the beginning or end of the tag.
Attachments (0)
Change History (8)
comment:1 Changed 13 years ago by
Keywords: | tag validation strip added |
---|---|
Owner: | changed from Alec Thomas to Steffen Hoffmann |
comment:2 follow-up: 4 Changed 13 years ago by
So if a sentence ends with a word, it is in one tag, and if it is somewhere else in the sentence it is a different tag? I really fail to see the logic. Without this, things like generating tags from ticket summaries is not possible. I do not think it makes sense to say summaries cannot contain punctuation.
comment:3 Changed 13 years ago by
I don't deny your reasons for your application.
But this is not necessarily the requirement of all application. Are you sure, that no TracTags application relies on some form of symbols (even consider i18n) for differentiation of tags? I'm not. At least we'll need to configure, what symbols should be subject to stripping (quite easy), right?
comment:4 Changed 12 years ago by
Replying to anonymous:
So if a sentence ends with a word, it is in one tag, and if it is somewhere else in the sentence it is a different tag? I really fail to see the logic. Without this, things like generating tags from ticket summaries is not possible.
Ok, point taken. I've some changes to make this happen, but these will require some more work due to compatibility issues with older Trac versions.
Could we agree on an optionally strict (sanitizing) and loose (current) treatment of tag input to not break things for someone else?
If this is not more an enhancement than a defect is debatable too, from my point of view.