To: field gets set to "email_to value"@trac.server.domain

[anonymous]

In distributors/mail.py, the value of the 'To' header is inexplicably placed inside quotation marks. This causes it to end up being appended by the Trac server’s domain.

[anonymous]

I suspect that this has something to do with the DefaultDomainResolver. If you don't need it, disable it. I'll try to get this fixed. Can you paste your settings and explain exactly where email_to value is entered?

[anonymous]

DefaultDomainResolver is already disabled on our installation. The email_to value was entered in trac.ini as:

[announcer]
email_address_resolvers = SpecifiedEmailResolver,SessionEmailResolver
email_enabled = true
email_sender = SendmailEmailSender
email_to = nobody@example.com
mime_encoding = qp
never_notify_updater = true
subscription_resolvers = SubscriptionResolver
use_threaded_delivery = true

Currently, I’ve modified the our code to stop adding quotation marks and modified the part that checked for a match against a quoted version of undisclosed-recipients: ; and it is working fine.

[Chris Shelton]

I have noticed the exact same behavior on a new install of trac 0.12, using the svn version of the announcerplugin (as of r9404). After a little bit of digging in the code, I implemented a similar patch as described in comment:2.

[Chris Shelton]

diff to allow To header to be undisclosed-recipients: ;

[Ryan J Ollos]

#8462 might be a duplicate.

[Steffen Hoffmann]

I think the following change should have resolved the issue, that has been reported and discussed here:

(In [12326]) TracAnnouncer: Don't attempt email distribution without recipients, refs #7834.

Felt like a re-arranged and slightly simplified code would make it easier to implement the requested check in EmailDistributor._do_send. IMHO it did.

The problematic check, that has a suggested patch here, is done differently now - before setting the headers, so quotation shouldn't cause issues anymore. Test feedback appreciated.

[bas.vandervlies@…]

I just installed the trunk version and also have this problem. The domain is appended to the to-field. Is there a fix for it?

[Ryan J Ollos]

Please post your sanitized [announcer] configuration and I will try to reproduce with the latest version of the AnnouncerPlugin code.

[bas.vandervlies@…]

just back from holidays:

[components]
announcer.* = enabled
announcer.resolvers.defaultdomainemailresolver = disabled
announcer.resolvers.specifiedemailresolver = disabled

[announcer]
always_notify_cc = true
always_notify_component_owner = true
default_email_format = text/plain
email_address_resolvers = SessionEmailResolver
email_always_cc = bas.van.der.vlies@...
email_enabled = true
email_from = bvlies@xs4all.nl
email_from_name = Email2Trac Test
email_replyto = bvlies@...
email_sender = SmtpEmailSender
email_to = linux-tg@...
use_threaded_delivery = true

[smtp]
debuglevel = 100
port = 25
server = localhost
timeout = 10

[bas.vandervlies@…]

Still have the problem that the to addres is wrong:

• linux-tg@…"@itrac.osd.surfsara.nl

Has somebody a patch for it?

[anonymous]

I found out the problem. I have installed postfix as MTA and the announcer puts quotes around the to field. So it is considered as string. The patch below fixes the problem

announcer/distributors/mail.py

@@ -416 +416 @@
             if self.to == self.to_default:
                 headers['To'] = _('undisclosed-recipients: ;')
             else:
-                headers['To'] = '"%s"' % self.to
+                headers['To'] = '%s' % self.to
                 if self.to:
                     recip_adds += [self.to]
         if not recip_adds:

[Tiago Teresa Teodósio]

This patch worked for me, thanks!

[bas.vandervlies@…]

I'll hope that they release a new version or is the development stopped?

[Ryan J Ollos]

At the very least, development has been paused for far too long.

hasienda: do you have an opinion on the patch in comment:12? I'd be happy to do some additional testing and push it.

[Ryan J Ollos]

Please upgrade to Trac 1.2, which has integrated the core of AnnouncerPlugin. Please raise the issue on the ​trac:MailingList if you encounter the issue with Trac 1.2.