Modify ↓
#7834 closed defect (fixed)
Emails are attempted to be sent even when there are no recipients
| Reported by: | anonymous | Owned by: | Steffen Hoffmann |
|---|---|---|---|
| Priority: | normal | Component: | AnnouncerPlugin |
| Severity: | normal | Keywords: | email notification |
| Cc: | Ryan J Ollos, Robert Corsaro | Trac Release: | 0.12 |
Description (last modified by )
Before starting delivery, EmailDistributor._do_send should check the length of recip_adds and only send email, if there are actually recipients.
Attachments (0)
Change History (6)
comment:1 Changed 12 years ago by
| Cc: | Ryan J Ollos Robert Corsaro added; anonymous removed |
|---|---|
| Description: | modified (diff) |
| Keywords: | email notification added |
| Owner: | changed from Robert Corsaro to Steffen Hoffmann |
comment:2 Changed 12 years ago by
comment:3 Changed 12 years ago by
But events without subscription won't even fire EmailDistributor, so I'm currently at a loss, how to test this. Ideas?
comment:4 Changed 8 years ago by
| Owner: | Steffen Hoffmann deleted |
|---|
comment:5 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 Changed 8 years ago by
| Owner: | set to Steffen Hoffmann |
|---|
Note: See
TracTickets for help on using
tickets.
(In [12326]) TracAnnouncer: Don't attempt email distribution without recipients, refs #7834.
Felt like a re-arranged and slightly simplified code would make it easier to implement the requested check in
EmailDistributor._do_send. IMHO it did.