[TracCiaPlugin] Wrong ticket link and postgresql error

[Oliver Metz]

When a new ticket is created the link is displayed like this:

http://trac.freetz.org/ticket/459/459

The ticket number is appended twice. Attached is a patch to fix this and a postgresql error I got. (Sorry, lost error message. It was something like comment is not a valid column.)

__init__.py

@@ -200 +200 @@
         elif action == 'created':
             args['url'] = t_url + '/' + str(ticket.id)
             args['log'] = 'Created ['+ticket['type']+']: ('+ticket['summary']+')' + (version and (' in ' + version) or '')
-            args['log'] += ' (' + t_url + '/' + str(ticket.id) + ')'
+            args['log'] += ' (' + t_url + ')'
         elif action == 'changed':
             old = kwargs.get('old_values', {})
             db = self.env.get_db_cnx()
             cursor = db.cursor()
-            cursor.execute('SELECT count(*) FROM ticket_change WHERE ticket = %s and field = "comment"' % (ticket.id));
+            cursor.execute("SELECT count(*) FROM ticket_change WHERE ticket = %s and field = 'comment'" % (ticket.id));
             r = cursor.fetchone()
             num_comments = int(r and r[0] or 0)
             if num_comments:

[Mikhail Gusarov]

Did you try the latest svn version? I fixed the similar bug some time ago.

[Oliver Metz]

Sure I did. If you look at the two lines argsurl? and argslog? you will see that the ticket id is appended twice.

[Mikhail Gusarov]

PostgreSQL fix committed.

Though I still don't see the problem with ticket.id: args['url'] = t_url + '/' + str(ticket.id) does not change the value of t_url, so it's necessary to append the id again while adding the link to the log.

Anyway, either both url/log links should have ticket id appended, or both should not have it, depending on the actual value of t_url.

[Oliver Metz]

Sorry. You are right. I will take a closer look and try to find my problem.

[Mikhail Gusarov]

Okay, so I'm closing this ticket.

Thanks for SQL fix.

[Oliver Metz]

Can you explain to me why ticket delete and ticket changed methods don't need this str(ticket.id) in the url and log but the ticket create method does?

Can you give me a hint how I can do "dry runs" without creating a real ticket and how I can log something into trac.log?

Thank you.

[Mikhail Gusarov]

Ask the trac guys :) Arguments are non-consistent.

Regarding dry runs - no idea. I'm just using a local test trac instance.

[Oliver Metz]

Next new ticket was created. Log message as follows:

CIA-1: Whoopie tickets/kernel * #461 /: Created [defect]: (7170 crashes with usb-root and "replace kernel") in devel (http://trac.freetz.org/ticket/461/461)

I'm using the actual svn revision without modifications.

[Oliver Metz]

With this patch I get the following message:

traccia/__init__.py

@@ -201 +201 @@
             args['url'] = t_url + '/' + str(ticket.id)
             args['log'] = 'Created ['+ticket['type']+']: ('+ticket['summary']+')' + (version and (' in ' + version) or '')
             args['log'] += ' (' + t_url + '/' + str(ticket.id) + ')'
+            self.log.warn('Ticket URL: %s', t_url)
         elif action == 'changed':
             old = kwargs.get('old_values', {})
             db = self.env.get_db_cnx()

trac.log:

2009-06-05 10:03:32,270 Trac[__init__] WARNING: Ticket URL: http://trac.freetz.org/ticket/462

[Mikhail Gusarov]

Interesting, maybe it's version-dependent.

I'll have a look.

[Mikhail Gusarov]

Yes, confirmed, and fix committed in r6389.