Date/time in commit history table is not localized

[t.riedel@…]

For a trac displayed in german language the date/time in the table of commit history is not localized.

It displays 09/08/14 10:18:59 where I expect it to display 08.09.2014 10:18:59 like it is done when viewing the changeset in the svn browser of trac.

[Steffen Hoffmann]

Sure, this may count as a defect since this plugin advertized i18n support.

As seen in #11983 this has been done rather incompletely. Thanks for reporting, we'll fix the localized time formatting, and update the i18n support altogether too.

[Jun Omae]

In Trac 1.0 and later, format_datetime should be used with user_time helper. Could you please try the following patch?

tracticketchangelogplugin/0.12/ticketlog/web_ui.py

@@ -29 +29 @@
     from trac.util.datefmt import from_utimestamp as from_timestamp
 except ImportError:
     from trac.util.datefmt import from_timestamp
+try:
+    from trac.util.datefmt import user_time
+except ImportError:
+    def user_time(req, func, *args, **kwargs):
+        if 'tzinfo' not in kwargs:
+            kwargs['tzinfo'] = getattr(req, 'tz', None)
+        return func(*args, **kwargs)
 
 from i18n_domain import _, N_, add_domain, gettext, tag_
 
@@ -181 +188 @@
             revision = {
                 'rev': rev,
                 'author': Chrome(self.env).format_author(req, author),
-                'time': format_datetime(from_timestamp(timestamp),
-                                        tzinfo=req.tz)
+                'time': user_time(req, format_datetime,
+                                  from_timestamp(timestamp)),
             }
             if self.max_message_length \
                     and len(message) > self.max_message_length:

[t.riedel@…]

Applied the patch and tested it. Looks good: Timestamp is now formatted as expected:

08.09.2014 10:18:59

Thanks a lot.

[Ryan J Ollos]

Replying to jun66j5:

In Trac 1.0 and later, format_datetime should be used with user_time helper. Could you please try the following patch?

Change looks good to me. Please feel free to commit it.

[Jun Omae]

In 14174:

TracTicketChangelogPlugin: (i18n) display localized date/time in commit history with Trac 1.0 and later (fixed #11984)