Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11983 closed enhancement (fixed)

Section title "Changelogs" is hard-coded and not translatable

Reported by: t.riedel@… Owned by: Steffen Hoffmann
Priority: normal Component: TracTicketChangelogPlugin
Severity: normal Keywords: i18n
Cc: Ryan J Ollos Trac Release: 0.12

Description

The title of the section created by this plug-in in a ticket is hard-coded in the line 19 of the following file:

source:tracticketchangelogplugin/0.12/ticketlog/htdocs/ticketlog.js@13954#19

It is not translatable in this case.

Together with requesting a translatable section name I propose to change it from Changelogs to Commit History to avoid confusion with Change History.

Attachments (1)

TracTicketChangelogPlugin_translation_de_DE.patch (8.7 KB) - added by Steffen Hoffmann 10 years ago.
proposed patch including various i18n-related changes as provided by Torge Riedel via mailing-list

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by Steffen Hoffmann

Cc: Ryan J Ollos added; anonymous removed
Keywords: i18n added

I offer to review this as well as other i18n-related issues reported to the mailing-list before on behalf of Ryan who seem to step in for the author and previous maintainer Richard?

Changed 10 years ago by Steffen Hoffmann

proposed patch including various i18n-related changes as provided by Torge Riedel via mailing-list

comment:2 Changed 10 years ago by Steffen Hoffmann

In 14169:

TracTicketChangelogPlugin: Fix i18n docs, extract messages add German translations, refs #11983.

Thanks to Torge Riedel for preparing these changes.

comment:3 in reply to:  description ; Changed 10 years ago by Ryan J Ollos

Replying to t.riedel@…:

Together with requesting a translatable section name I propose to change it from Changelogs to Commit History to avoid confusion with Change History.

Yeah, I think it would be good to change the section title to Commit History.

comment:4 Changed 10 years ago by Steffen Hoffmann

In 14170:

TracTicketChangelogPlugin: (i18n) Provide more messages for translation, refs #11983.

Move texts from js file to python script for translation, since a separate js
message catalog would be overkill for this plugin.

Message catalog and translation update as well as some PEP8 changes
(line-length) are included as well.

comment:5 in reply to:  3 Changed 10 years ago by Steffen Hoffmann

Replying to rjollos:

Replying to t.riedel@…:

Together with requesting a translatable section name I propose to change it from Changelogs to Commit History to avoid confusion with Change History.

Yeah, I think it would be good to change the section title to Commit History.

Thanks for the feedback. I did the change, but I'm still open to suggestions for a more appropriate German translation. Anyway, if we agree to keep the current state, I'm fine with closing this ticket.

comment:6 Changed 10 years ago by t.riedel@…

Mmmh

  • Updated the plug-in in my instance to the latest revision
  • Restarted apache

But I do not see german texts.

comment:7 Changed 10 years ago by t.riedel@…

Sorry, my fault. Forgot to compile the catalogs and had two parallel installations.

comment:8 Changed 10 years ago by t.riedel@…

There is one more thing: The date/time in the table is not localized. Created ticket #11984 for this bug.

comment:9 in reply to:  7 Changed 10 years ago by Steffen Hoffmann

Resolution: fixed
Status: newclosed
Trac Release: 1.00.12

Replying to t.riedel@…:

Sorry, my fault. Forgot to compile the catalogs and had two parallel installations.

The i18n support should be updated, so that it is done for you while packaging the source. Anyway, glad to get the confirmation that it works.

comment:10 Changed 10 years ago by Ryan J Ollos

Owner: changed from Richard Liao to Steffen Hoffmann

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Steffen Hoffmann.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.