Don't work if no milestone defined

[gdoumenc@…]

If there is no milestone defined.. (perhaps bad idea but..) filter_milestone.js crashes as no options found...

[Ryan J Ollos]

Which plugin is this report for?

[falkb]

Please, provide the circumstances of the crash:

• Versions of Trac, Python, used internet browser and svn version of SimpleMultiProjectPlugin
• exact javascript error text (seen in browser debugger?)

[falkb]

Replying to gdoumenc@coworks.pro:

If there is no milestone defined.. (perhaps bad idea but..) filter_milestone.js crashes as no options found...

Do you have no milestone in the whole Trac instance, or just for a certain project?

[anonymous]

No milestone in the whole instance..

In code for milestone (select), there is no options and options is null!!

...
    if (select.prop) {
        options = select.prop('options');
    }
    else {
        options = select.attr('options');
    }
...

[falkb]

Please, apply testwise:

simplemultiprojectplugin/trunk/simplemultiproject/htdocs/filter_milestones.js

@@ -12 +12 @@
     select.empty();
 
     var addedOptions = [];
-    if (newOptions) {
+    if (options && newOptions) {
         $.each(newOptions, function(val, text) {
             var isSelected = (selectedOption && text == selectedOption);
             options[options.length] = new Option(text, text, isSelected, isSelected);
@@ -20 +20 @@
         });
     }
 
-    if (selectedOption && $.inArray(selectedOption, addedOptions) == -1) {
+    if (options && selectedOption && $.inArray(selectedOption, addedOptions) == -1) {
         options[options.length] = new Option(selectedOption, selectedOption, true, true);
     }

Better now?

[anonymous]

Sorry, I used egg to install so I don't know where to do the change.. ;(

[falkb]

Replying to anonymous:

Sorry, I used egg to install so I don't know where to do the change.. ;(

Now I've committed [12547] to SVN which may help. Please, reinstall the new egg, and report back.

[anonymous]

working

[falkb]

Thanks a lot. Most work of software programming goes to the handling of special cases.