trac-admin script hangs when TracDeveloperPlugin is enabled

[anonymous]

Then the TracDeveloperPlugin is enabled, the trac-admin script does not exit after it is done. This only happens for trac-admin subcommands that load the plugin, like e.g. trac-admin deploy.

I guess this is because of the thread started by the plugin.

[Ryan J Ollos]

Replying to olemis:

• Owner changed from olemis to anonymous

I've noticed this a few times when you've accepted tickets - if you accept a ticket without logging in, it will be assigned to anonymous. Just fyi. See also #7397 and #11455.

I'll see if we can modify the workflow to avoid this scenario.

[Olemis Lang]

I can't reproduce this issue running Trac=1.0 . May I close this ticket with resolution=worksforme ?

@rjollos : I typed my user name in author box . So ... maybe this is an issue ?

I'm honestly not keen to login to web sites unless they offer open auth mechanisms e.g. OpenId

[Ryan J Ollos]

I replied to your comment in comment:2:ticket:11457.

[Ryan J Ollos]

Replying to olemis:

I can't reproduce this issue running Trac=1.0.

Reproduced with Trac trunk (​trac:r14100) and TracDeveloperPlugin r14629 using trac-admin deploy. Here is the DEBUG level console output before the hang:

Copying resources from:
  trac.web.chrome.Chrome
    /Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/htdocs
    /Users/rjollos/Documents/Workspace/trac-dev/proj-1.1/htdocs
  tracdeveloper.main.DeveloperPlugin
    /Users/rjollos/Documents/Workspace/trac-dev/tracdeveloperplugin/trunk/tracdeveloper/htdocs
  tracdeveloper.dozer.Dozer
    /Users/rjollos/Documents/Workspace/trac-dev/tracdeveloperplugin/trunk/tracdeveloper/dozer/htdocs
Creating scripts.
14:36:15 Trac[__init__] DEBUG: templates=/Users/rjollos/Documents/Workspace/trac-dev/tracdeveloperplugin/trunk/tracdeveloper/dozer/templates

[Jun Omae]

Reproduced with Trac 1.0.6. I consider that issue must be reproduced with all versions of Trac.

When constructing Dozer component in tracdeveloper/dozer/__init__.py, the component creates a non-daemon thread. As the result, the python interpreter waits termination of the thread.

tracdeveloperplugin/trunk/tracdeveloper/dozer/__init__.py

@@ -71 +71 @@
         self.history = {}
         self.samples = 0
         self.runthread = threading.Thread(target=self.start)
+        self.runthread.setDaemon(True)
         self.runthread.start()
 
     # IRequestHandler methods

Another suggestion is removing ITemplateProvider implementation from the Dozer component (or moving it to another component).

[Ryan J Ollos]

Thank you for the suggestion and patch. How does the following look?

tracdeveloper/dozer/__init__.py

@@ -7 +7 @@
 from StringIO import StringIO
 from types import FrameType, ModuleType
 
-from pkg_resources import resource_filename
 # 
 # import Image
 # import ImageDraw
@@ -14 +13 @@
 
 from trac.core import *
 from trac.web.api import IRequestHandler, HTTPNotFound, HTTPForbidden
-from trac.web.chrome import ITemplateProvider, add_stylesheet, add_script
+from trac.web.chrome import add_stylesheet, add_script
 
 from genshi.core import Markup
 from genshi.builder import tag
@@ -21 +20 @@
 
 # from paste import fileapp
 # from paste import urlparser
-# from pkg_resources import resource_filename
 # from webob import Request, Response
 # from webob import exc
 
@@ -65 +63 @@
     period = 5
     maxhistory = 300
     
-    implements(IRequestHandler, ITemplateProvider)
+    implements(IRequestHandler)
     
     def __init__(self):
         self.history = {}
         self.samples = 0
         self.runthread = threading.Thread(target=self.start)
+        self.runthread.setDaemon(True)
         self.runthread.start()
     
     # IRequestHandler methods
@@ -93 +92 @@
         add_stylesheet(req, 'dozer/main.css')
         return method(req)
     
-    # ITemplateProvider methods
-    def get_htdocs_dirs(self):
-        yield 'dozer', resource_filename(__name__, 'htdocs')
-            
-    def get_templates_dirs(self):
-        self.log.debug('templates=%s', resource_filename(__name__, 'templates'))
-        yield resource_filename(__name__, 'templates')
-    
     # Internal methods
     def start(self):
         self.running = True

tracdeveloper/main.py

@@ -43 +43 @@
 
     def get_templates_dirs(self):
         from pkg_resources import resource_filename
-        return [resource_filename(__name__, 'templates')]
+        return [resource_filename('tracdeveloper', 'templates'),
+                resource_filename('tracdeveloper.dozer', 'templates')]
 
     def get_htdocs_dirs(self):
         from pkg_resources import resource_filename
-        return [('developer', resource_filename(__name__, 'htdocs'))]
+        return [('developer', resource_filename('tracdeveloper', 'htdocs')),
+                ('dozer', resource_filename('tracdeveloper.dozer', 'htdocs'))]
 
     # IPreferencePanelProvider methods
     def get_preference_panels(self, req):

[Jun Omae]

Looks good to me!

[Ryan J Ollos]

In 14644:

TracDeveloper 0.3.0dev: Fix trac-admin script hanging. Fixes #9984.

• Dozer thread runs in daemon mode.
• ITemplateProvider moved from dozer to main.

Thanks to Jun Omae for the patch.