Opened 14 years ago
Closed 14 years ago
#8755 closed defect (fixed)
Using id="attachments" causes problems with other plugins
Reported by: | N@ | Owned by: | Mark Ryan |
---|---|---|---|
Priority: | normal | Component: | ChildTicketsPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.12 |
Description
When I have ChildTicketsPlugin installed with then TracTicketChangesetsPlugin, the changesets generated by TracTicketChangesetsPlugin for the ticket appear twice.
This is because the ChildTicketsPlugin is using the "attachments" id for it's div tag. The TracTicketChangesetsPlugin is filtering the template stream looking for this ID so it knows when to insert it's section, sees "attachments" twice, and inserts it's section twice.
Obviously, TracTicketChangesetsPlugin needs to be fixed as well, but ChildTicketsPlugin should use something unique for it's section id, like "childtickets" (line 135 or [10110]):
snippet = tag.div(id="childtickets")
You can get the same effect by using the "changelog" id (line 211 of [10110]):
snippet.append(tag.div(tablediv, buttondiv, id="changelog"))
Mind you, this could end up having the same effect if someone filters the stream on "changelog"! So, maybe you could create your own id instead?
Ultimately, some of these styles that people are going to want to use should be moved from CSS ids to classes, but this is obviously out of your control. :)
I'm also going to put a bug against TracTicketChangesetsPlugin.
Attachments (0)
Change History (2)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
I have the same problem. See #8757