PATCH: Python 2.4 compatibility.

[koeppj@…]

On build or install (python setup.py bdist_eng) I get the following error for a number of items. Start of log snippet

byte-compiling build/bdist.linux-x86_64/egg/tracdiscussion/api.py to api.pyc
  File "build/bdist.linux-x86_64/egg/tracdiscussion/api.py", line 1334
    'where' : 'WHERE ' + where if where else ''}
                                ^
SyntaxError: invalid syntax

Running this on RHEL 3.4 x64 with python 2.4 - revision 9598.

[koeppj@…]

Realized this problem was due to use of python 2.5 inline conditionals. Suggest the docs get updated to indicate python 2.5 is a prereq or use the api.py I've addition.

[Radek Bartoň]

Thank you for pointing this out. I'll mention it on the wiki page rather than fixing it. BTW: Attaching a patch would be more appreciated by potential users that has to use older Python versions.

[anonymous]

Updated api.py is attached to this ticket. I'm not a python guru (I'm more a java guy) so I'm sure this is a more elegant way to fix but the api.py file attached to this ticket was compiled and runs on python 2.4. I'm note a registered user so can't create a proper patch.

[Ryan J Ollos]

Replying to anonymous:

I'm note a registered user so can't create a proper patch.

Registration is not required to checkout a project branch. You can then use svn diff and output to a file.

[koeppj@…]

Just realized that. Will upload one. Look for run_on_python_24.patch attached to this ticket.

[koeppj@…]

Patch to allow plugin to run on Python version 2.4

[Radek Bartoň]

Thank you.

[Guido U. Draheim]

I am using the following patches for Python 2.4 compatibility:

trac-discussion-plugin/trac-discussion-plugin.no-ifelse-api-01.patch trac-discussion-plugin/trac-discussion-plugin.no-ifelse-timeline-01.patch

Prebuilt packages for CentOS-5 / RHEL5 can be downloaded from the Open Build Service at ​https://build.opensuse.org/package/show?package=trac-discussion-plugin&project=home%3Aguidod%3Atrac12

[dizzystreak]

Replying to guidod:

I am using the following patches for Python 2.4 compatibility:

trac-discussion-plugin/trac-discussion-plugin.no-ifelse-api-01.patch trac-discussion-plugin/trac-discussion-plugin.no-ifelse-timeline-01.patch

Prebuilt packages for CentOS-5 / RHEL5 can be downloaded from the Open Build Service at ​https://build.opensuse.org/package/show?package=trac-discussion-plugin&project=home%3Aguidod%3Atrac12

Unfortunately, there is more python2.5 style code in the plugin. Here is an example error message with the line number:

TemplateSyntaxError: invalid syntax (/usr/lib/python2.4/site-packages/tracdiscussion/templates/discussion-macros.html, line 55)

[Ryan J Ollos]

#9146 closed as a duplicate.

[Ryan J Ollos]

#8803 closed as a duplicate.

[Ryan J Ollos]

(In [12057]) Fixes #9963, Refs #9800, #8276, #8803, #9146: Added check in setup.py for minimum required Python version. Python 2.5 is currently required. Later, we'll aim to restore full Python 2.4 compatibility.

[Steffen Hoffmann]

Replying to rjollos:

Later, we'll aim to restore full Python 2.4 compatibility.

Just what I noted to #6783 now. I've already cleaned an occurrence of 'if..else' in timeline event provider code (see [13882]). Will try to remember recording related changes here.

[Steffen Hoffmann]

Trying to pull changes from the resource advertised by guidod I see, that trac-discussion-plugin.no-ifelse-timeline-01.patch changes is essentially what I've already spotted and fixed in [13882] before.

However the more extensive trac-discussion-plugin.no-ifelse-api-01.patch changeset is still a very valuable contribution.

[Steffen Hoffmann]

In 13886:

DiscussionPlugin: Bring full Trac 0.11 compatibility, closes #8276.

Most of these changes have been kindly contributed by Guido Draheim.
Thanks a lot for your time, encouraging me even more to find the remaining
places - Python code hidden in Genshi HTML template markup.

[Steffen Hoffmann]

Since I failed to do a manual full install of Python2.4 (couldn't fix missing zlib) I could only do a load test for all modules. Please re-open this ticket in case we need more things to get fixed.