Opened 18 years ago
Closed 18 years ago
#795 closed defect (fixed)
AddComment does not post, preview, or cancel.
Reported by: | Owned by: | Alec Thomas | |
---|---|---|---|
Priority: | high | Component: | AddCommentMacro |
Severity: | normal | Keywords: | |
Cc: | Stephan.Wacker@…, blach@…, nicholas, Robert Kieffer | Trac Release: | 0.10 |
Description
When I click Add Comment, Preview, or Cancel, it attempts to load, e.g. /wiki/MyWikiPage#commentpreview
and there is simply a "Create this page" button, nothing else.
I've just upgraded to 0.10.1dev; if it is a configuration issue, no such indications were given on the hack's description page.
Attachments (0)
Change History (14)
comment:1 Changed 18 years ago by
Priority: | normal → high |
---|
comment:2 Changed 18 years ago by
Resolution: | → worksforme |
---|---|
Status: | new → closed |
Works for me using 0.10.3. This could have been an artifact of the CSRF protection.
comment:3 follow-up: 4 Changed 18 years ago by
Resolution: | worksforme |
---|---|
Status: | closed → reopened |
would have been nice but still doesn't work for me
comment:4 Changed 18 years ago by
Replying to harald:
would have been nice but still doesn't work for me
Did you modify the macro at all? It seems to be using POSTs where it should be using GETs.
comment:5 Changed 18 years ago by
egbert:/home/harald/trac-stuff/addcommentmacro/0.10# svn up At revision 1851. egbert:/home/harald/trac-stuff/addcommentmacro/0.10# svn status ? build ? TracAddCommentMacro.egg-info ? temp
therefore no :)
I'm running trac on an apache webserver using mod_python, could this somehow interfere?
comment:6 Changed 18 years ago by
Trac Release: | 0.9 → 0.10 |
---|
Yes, the code in svn (as of r1855) is using 'post' as the method.
Changing the method='post' to method='get' has solved the problem for me. (on 0.10.3)
comment:8 follow-up: 9 Changed 18 years ago by
Switching from post to get might fix the code, but it is definitely not an appropriate use of HTTP GET.
comment:9 Changed 18 years ago by
Replying to paul@prescod.net:
Switching from post to get might fix the code, but it is definitely not an appropriate use of HTTP GET.
Agreed. People can (and do) reload a page and double post a comment. Does anybody have a better fix yet? Thanks.
comment:10 Changed 18 years ago by
Cc: | Stephan.Wacker@… added; anonymous removed |
---|
comment:11 Changed 18 years ago by
Cc: | blach@… added |
---|
comment:12 Changed 18 years ago by
Cc: | nicholas added |
---|
comment:13 Changed 18 years ago by
Cc: | Robert Kieffer added |
---|
comment:14 Changed 18 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Please upgrade to the latest version. This should pull in the MacroPostPlugin, which will fix the issue.
Same behavior here using 0.10.