Add Compatibility for LDAP servers other than ActiveDirectory

[Vincent]

I modified the plugin a bit to add some flexibility as to easily support openLDAP and other custom setups.

While my own setup could not work with the original plugin, the modifications I made should not break installed setups (except maybe because of default values in rare cases)

Please contact me at the email I used in the file headers.

[Vincent]

Experimental flexibility for openLDAP

[John Hampton]

OK, first, this is neither high priority, nor is it a blocker of any kind.

I looked at the changes and they are reasonable. However, I have a few questions:

Why use the ActiveDirectoryAuthPlugin instead of one of the other LDAP auth plugins such as: TracLdapAuthPlugin or LdapAuthStorePlugin?

I'm not against modifying the ActiveDirectoryAuthPlugin, just seemed a bit of an interesting choice as it's clearly aimed at Active Directory rather than generic LDAP.

Expanding it beyond Active Directory also means that a name change may be in order. Unfortunately, with so may other "LDAP" plugins, just naming it "LDAP" something might not work. Name ideas? Perhaps simply clearer documentation?

Did you have any other ideas for the plugin?

[branson]

No comments on this .. I think it's a 'wont'fix' If there's enough interest in this .. I may revisit/combine a few of the plugins mentioned to resolve this.