[patch] charset="us-ascii" in text part of html announcement

[Dmitri]

When I choose the 'text/html' announcement format the first part of multipart/alternative mime has Content-Type: text/plain; charset="us-ascii", but second - Content-Type: text/html; charset="utf-8"

[announcer]
mime_encoding = qp

Why? How can I change this behavior?

The message contains cyrillic characters. Then I choose multiple messages in Thunderbird, it displays something like Приоритет. MS Outlook displays such characters always.

[Dmitri]

Alternative part appears without charset setting:

distributors/mail.py

@@ -489 +489 @@
 
             alt_msg_format = 'html' in alternate_style and 'html' or 'plain'
             msgText = MIMEText(alternate_output, alt_msg_format)
+            msgText.set_charset(self._charset)
             parentMessage.attach(msgText)
         else:
             parentMessage = rootMessage

[Steffen Hoffmann]

(In [12341]) TracAnnouncer: Apply suitable charset to alternative part of email message as well, refs #7791.

This fixes inappropriate alternative text display of non-ascii characters in HTML emails, that get sent out as multi-part message in MIME format.

This has been reported by g1itch, who did investigations and patch as well. Works like a breeze, but this must have been much harder to fix than one would expect at first glance onto this one-liner. It's a pleasure to follow your footsteps, thanks a bunch.

[Dmitri]

Still open?

[Steffen Hoffmann]

Replying to g1itch:

Still open?

Yeah, personal preference to keep tickets open for a while/next stable release, encouraging testers to report back as you did - thanks.

[Dmitri]

Replying to hasienda:

Replying to g1itch:

Still open?

Yeah, personal preference to keep tickets open for a while/next stable release, encouraging testers to report back as you did - thanks.

My personal preference is to apply patch and forget. I found this while looking for #10974.

[Ryan J Ollos]

Worksforme would certainly not be the proper resolution, regardless. Please leave tickets for project maintainer to manage as they see fit.

[Ryan J Ollos]

Please upgrade to Trac 1.2, which has integrated the core of AnnouncerPlugin. Please raise the issue on the ​trac:MailingList if you encounter the issue with Trac 1.2.