MovieMacro for 0.12

[anonymous]

is MovieMacro working on trac 0.12? I have installed last version of MovieMacro macros, but it don't work propetly.

[eamonn.power@…]

changing

htdocs://movie/img/black.jpg -> htdocs://movie/movie/img/black.jpg

and

htdocs://movie/swf/FlowPlayerDark.swf -> htdocs://movie/movie/swf/FlowPlayerDark.swf

in macro.py makes it work again.

[juha.mustonen@…]

Alternative solution is to change paths in get_absolute_url(?)

movie/macro.

@@ -48 +48 @@
         return url
 
     if scheme in ('htdocs', 'chrome'):
-        return ujoin(base, 'chrome', path)
+        return ujoin(base, 'chrome', netloc, path)
 
     if scheme in ('source',):
         return ujoin(base, 'export', path)
@@ -57 +57 @@
         return ujoin(base, 'raw-attachment/ticket', path)
 
     if scheme in ('wiki',):
-        return ujoin(base, 'raw-attachment/wiki', path)
+        return ujoin(base, 'raw-attachment/wiki', netloc, path)
 
     return url

[juha.mustonen@…]

And naturally the ticket path needs to be changed as well. Support for source (or other VCS backends on that matter) has not been changed/tested.

movie/macro.py

@@ -48 +48 @@
         return url
 
     if scheme in ('htdocs', 'chrome'):
-        return ujoin(base, 'chrome', path)
+        return ujoin(base, 'chrome', netloc, path)
 
     if scheme in ('source',):
         return ujoin(base, 'export', path)
 
     if scheme in ('ticket',):
-        return ujoin(base, 'raw-attachment/ticket', path)
+        return ujoin(base, 'raw-attachment/ticket', netloc, path)
 
     if scheme in ('wiki',):
-        return ujoin(base, 'raw-attachment/wiki', path)
+        return ujoin(base, 'raw-attachment/wiki', netloc, path)
 
     return url

[Ryan J Ollos]

The code should be refactored to make better use of the Trac API. I don't see much activity on the plugin lately, so I'll assume it's unmaintained and push a fix in a few moments.

[Ryan J Ollos]

Btw, I'm using these example files for testing: ​http://www.mediacollege.com/adobe/flash/video/tutorial/example-flv.html

[Ryan J Ollos]

(In [12015]) Refs #7422: (0.2dev)

• Refactored code to make better use of the Trac API when constructing URLs. This should resolve issues with incorrect URLs.

[Ryan J Ollos]

Please report back if you are able to test, and if I get some positive feedback I will close out the ticket.

[anonymous]

Confirmed: version 0.2dev-r12015 seems to work just fine.

Sources tested:

• wiki attachment
• ticket attachment
• youtube url

[Ryan J Ollos]

Thanks. I'm going to push a few more patches. I'll CC you on the tickets in case you might have an interested in testing out a newer version of the plugin.

[Ryan J Ollos]

(In [12038]) Refs #7422, #8808: Renamed 0.11 directory to trunk.