[Patch] Reports not working with Postgres 8.4 (TimingAndEstimation plugin)

[ricardo.ichizo@…]

The reports Ticket Hours Grouped By Client and Ticket Hours Grouped By Client with Description that are viewed by TimingAndEstimation plugin are sending invalid SQL statement to the database.

The description of the problem is attached in this ticket.

The following piece of code resolved the problem:

reports.py

@@ -70 +70 @@
        component as __component__,version, severity, milestone, status, owner,
        CAST(estimatedhours.value as DECIMAL) as estimate_work,
        CAST(totalhours.value as DECIMAL) as Total_work,
-       CASE WHEN billable.value = 1 THEN 'Y'
+       CASE WHEN billable.value = ($BILLABLE) THEN 'Y'
             else 'N'
        END as billable,
        time AS created, changetime AS modified,         -- ## Dates are formatted
@@ -131 +131 @@
   
   WHERE t.status IN ($NEW, $ASSIGNED, $REOPENED, $CLOSED) 
     AND billable.value in ($BILLABLE, $UNBILLABLE)
-  GROUP BY client.value
+  GROUP BY client.value, t.component
 )  as tbl
 ORDER BY __group__, _ord ASC,ticket
     """
@@ -153 +153 @@
        component as __component__,version, severity, milestone, status, owner,
        CAST(estimatedhours.value as DECIMAL) as estimate_work,
        CAST(totalhours.value as DECIMAL) as Total_work,
-       CASE WHEN billable.value = 1 THEN 'Y'
+       CASE WHEN billable.value = ($BILLABLE) THEN 'Y'
             else 'N'
        END as billable,
        time AS created, changetime AS modified,         -- ## Dates are formatted
@@ -214 +214 @@
   
   WHERE t.status IN ($NEW, $ASSIGNED, $REOPENED, $CLOSED) 
     AND billable.value in ($BILLABLE, $UNBILLABLE)
-  GROUP BY client.value
+  GROUP BY client.value, t.component
 )  as tbl
 ORDER BY __group__, _ord ASC,ticket
     """

[ricardo.ichizo@…]

Wrong type comparation

[ricardo.ichizo@…]

Wrong "group by" clause