[Patch] Make label "Breadcrumbs:" configurable

[anonymous]

Patch:

breadcrumbs.py

@@ -23 +23 @@
     supported_paths = ListOption('breadcrumbs', 'paths', '/wiki*,/ticket*,/milestone*',
         doc='List of URL paths to allow breadcrumb tracking. Globs are supported.')
+
+    label = Option('breadcrumbs','label','Breadcrumbs:',
+                   doc="""Text label to show before breadcrumb list""")
     
     compiled_ignore_pattern = None
@@ -160 +163 @@
             )
             
-        insert = tag.ul(class_="nav", id="breadcrumbs")(tag.lh("Breadcrumbs:"), li)
+        insert = tag.ul(class_="nav", id="breadcrumbs")(tag.lh(self.label), li)
 
         return stream | Transformer('//div[@id="metanav"]/ul').after(insert)

[Pontus Enmark]

This issue is also addressed in ​http://trac-hacks.org/attachment/wiki/BreadCrumbsNavPlugin/breadcrumbs.diff

[Steffen Hoffmann]

Replying to penmark:

This issue is also addressed in ​http://trac-hacks.org/attachment/wiki/BreadCrumbsNavPlugin/breadcrumbs.diff

Sure, thanks for the pointer.

For the sake of completeness true i18n support providing localization according to configured languages in browser might still be preferred, making the label just an additional option, overwriting i18n label/per language once and for all users.

I'll put this on top of aforementioned patch soon.

[Steffen Hoffmann]

finally and visibly taking over responsibility after official maintainership change

[Steffen Hoffmann]

(In [10892]) BreadCrumbsNavPlugin: Add configurable default list label, refs #7231 and #7790.

This modified version of the change suggested by anonymous reporter of #7231 and addressed in penmark's patch will work better with coming i18n support, with the drawback, that the implicit default value isn't visible within the configuration system. At least tried to address this by extending option doc.

[Steffen Hoffmann]

(In [10896]) BreadCrumbsNavPlugin: Tag long overdue maintenance release 0.2, closes #2463, #3965, #4037, #4411, #7036 and #7231.

Fix erroneously introduced version mismatch between changelog and setup.py.

[Ryan J Ollos]

Should I delete the two attachments on the BreadCrumbsNavPlugin wiki page?

[Steffen Hoffmann]

I've just copied these patch files with a reference on their original submission to #7790 and new ticket #9539 respectively.

So you can clean-up that wiki page now. Thanks for the suggestion.

[Ryan J Ollos]

Replying to hasienda:

So you can clean-up that wiki page now. Thanks for the suggestion.

Cleaned-up.