Modify ↓
Opened 14 years ago
Closed 14 years ago
#7226 closed defect (fixed)
[patch] march has error in navigation link
Reported by: | Owned by: | Steffen Hoffmann | |
---|---|---|---|
Priority: | normal | Component: | WikiTicketCalendarMacro |
Severity: | major | Keywords: | 0.11 0.12 navigation link |
Cc: | Ryan J Ollos | Trac Release: | 0.12 |
Description
There is a bug in the logic that detects when to add 9 months for the "Turn up". On line 497 it should read:
if month < 4:
not:
if month < 3:
I'm also not sure that "Turn up" makes as much sense as "Move to", "Change to", or some other phrase.
Attachments (0)
Change History (3)
comment:1 Changed 14 years ago by
Cc: | Ryan J Ollos added; anonymous removed |
---|---|
Owner: | changed from Ryan J Ollos to Steffen Hoffmann |
Summary: | Month of march errors off. → Month of march errors off |
comment:2 Changed 14 years ago by
Keywords: | 0.11 0.12 navigation link added |
---|---|
Status: | new → assigned |
Summary: | Month of march errors off → [patch] march has error in navigation link |
comment:3 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [8109]) WikiTicketCalendarMacro: Correct test condition for 3-months-back nav link, closes #7226.
Wrong test produced invalid navigation link with 'month=0', that raised an error instead of jumping back 3 months from every March. Thanks to David Byrne for report and suggested code change.
Note: See
TracTickets for help on using
tickets.
I confirm that this is a bug that was introduced with the 3rd set of navigation links and is valid for all versions but the old 0.10 branch.
The off-by-one due to wrong test condition for 3-month-back-nav link will hit every march. Fixed revisions will be release tonight. Thank you very much for testing.
May I ask for another ticket regarding the disputed wording for nav link tooltip, please? This is unrelated to the aforementioned bug, so it would help for better issue tracking
Besides I'm certainly open to get well-educated advice from native English speakers. Actually I made this up on my own to replace the ubiquitous 'Go to' by suggesting the turn up a calendar book page to be similar. But I might have been wrong.