[PATCH] Don't break on invalid queries

[Matthijs Kooijman]

When filtering report results, there might be no results (for example when the query is invalid). Instead, an error message is shown.

Currently, bmtt breaks the page by throwing an exception, preventing the real error message from being shown and confusing the user.

The attached patch makes bmtt check for the presence of the "numrows" value in the "report_views.html" view. If it is not present, nothing is changed.

[Matthijs Kooijman]

Patch against 0.11 version, r8017

[obs]

Cannot replicate issue against trac 0.11.7. Can you test against 0.11.7 if you still have issues provide details of your trac.ini and the query you're running.

[Matthijs Kooijman]

Yup, this still happens with 0.11.7. To reproduce, simply create an invalid report. I've tested with a report containing the following query:

SELECT

I'm attaching my trac.ini, though I don't think there is anything relevant in there (in particular the bmtt section is empty).

The exact error I get is:

 Trac detected an internal error:

KeyError: 'numrows'

[Matthijs Kooijman]

trac.ini showing the breakage

[Steven R. Loomis]

I changed this slightly, to just detect row_groups in teh second section.

Please put this in, so that reports don't break!

I can reproduce this on trac 11.7 with this report select distinct reporter as id, "froms" as blah from ticket

[Steven R. Loomis]

revised again- don't assume 'id' column

[Ryan J Ollos]

This plugin is deprecated in Trac 1.4 and later. See migration tips on BlackMagicTicketTweaksPlugin page.