r7731 breaks password reset notification

[anonymous]

After updating from r7730 to r7731, I was no longer able to receive password reset notifications via SMTP to my email address. r7730 works fine, I just tested it :)

Here is what I did:

• enabled Trac logging to file
• updated to accountmanager-r7730
• easy_install
• reset password using the web interface (Login -> "Forgot your password?")
• found a password reset notification in my mailbox, and the Trac logfile said:

  2010-04-21 19:04:55,869 Trac[notification] INFO: Sending SMTP notification to localhost:25 to [u'example@example.org']
  2010-04-21 19:04:55,881 Trac[notification] WARNING: sendmail from: "Trac" <trac@example.org> to [u'example@example.org']
  2010-04-21 19:04:56,149 Trac[api] INFO: Updated password for user: rohieb
  

(of course, example.org was in fact my domain name ;-))

• updated to accountmanager-r7731
• easy_install
• reset password using the web interface (Login -> "Forgot your password?")
• found no mail in my mailbox, but also no lines from Trac[notification] in the logfile, although the same line from Trac[api] existed. Obviously, the handlers in Trac[notification] are not called, but my password is reset!

I am not a very good Python/Trac hacker, but I may be able to create a patch if I have the time.

[anonymous]

After updating from r7730 to r7731, I was no longer able to receive password reset notifications via SMTP to my email address. This is not the case with r7730.

Here is what I did:

• enabled Trac logging to file
• updated to accountmanager-r7730
• easy_install
• reset password using the web interface (Login -> "Forgot your password?")
• found a password reset notification in my mailbox, and the Trac logfile said:

  2010-04-21 19:04:55,869 Trac[notification] INFO: Sending SMTP notification to localhost:25 to [u'example@example.org']
  2010-04-21 19:04:55,881 Trac[notification] WARNING: sendmail from: "Trac" <trac@example.org> to [u'example@example.org']
  2010-04-21 19:04:56,149 Trac[api] INFO: Updated password for user: rohieb
  

(of course, example.org was in fact my domain name ;-))

• updated to accountmanager-r7731
• easy_install
• reset password using the web interface (Login -> "Forgot your password?")
• found no mail in my mailbox, but also no lines from Trac[notification] in the logfile, although the same line from Trac[api] existed. Obviously, the handlers in Trac[notification] are not called, but my password is reset!

I am not a very good Python/Trac hacker, but I may be able to create a patch if I have the time.

[rohieb@…]

(add myself to cc)

[Olaf Meeuwissen <olaf.meeuwissen@…>]

Looks like #6814 and #6817 are related.

[Olaf Meeuwissen <olaf.meeuwissen@…>]

Setting

acct_mgr.notification.AccountChangeListener = enabled

made SMTP notification work again for me.

For better or for worse (worse if you ask me), r7731 moves the password reset and email verification SMTP notifications to the AccountChangeListener API. If that component is not enabled, the SMTP notifications are never generated. Passwords are reset and permissions temporarily revoked nevertheless.

[stuge]

Yes, I'd say this is the same issue as #6814

[jack+trac@…]

Replying to Olaf Meeuwissen <olaf.meeuwissen@avasys.jp>:

Setting

acct_mgr.notification.AccountChangeListener = enabled

made SMTP notification work again for me.

Not for me. It took me hours to figure out. What eventually fixed it was this:

acct_mgr.notification.accountchangelistener = enabled

That is, it's case-sensitive.