[patch] WikiRenamePlugin doesn't invalidate wiki page name cache after moving page

[Steffen Hoffmann]

observed behavior:

0. access page with valid call for WikiTicketCalendarMacro, see: some day has not yet a corresponding wiki page (i.e. "2" of Mar 2010 isn't highlighted as if page no exists)
1. create wiki page through link provided by WikiTicketCalendarMacro calender (i.e. http:/<trac_url>/wiki/Cal/2010-03-02)
2. access new page directly via ​http://<trac_url>/wiki/<new page> (i.e. typing http:/<trac_url>/wiki/Cal/2010-03-02 into browser) - success
3. access page with valid call for WikiTicketCalendarMacro, see: day in question highlighted now
4. access wiki page through link provided by WikiTicketCalendarMacro calender - success
5. rename new page with WikiRenamePlugin respecting actual syntax of WikiTicketCalendarMacro call in question (i.e. wiki/Cal/2010-03-02 -> wiki/Cal/2010-03-03)
6. access renamed page directly via ​http://<trac_url>/wiki/<renamed page> (i.e. typing http:/<trac_url>/wiki/Cal/2010-03-03 into browser) - success
7. access pages old location directly via ​http://<trac_url>/wiki/<new page> (i.e. typing http:/<trac_url>/wiki/Cal/2010-03-02 into browser) - page missing as expected
8. access page with unchanged call for WikiTicketCalendarMacro, i.e. see:
   1. link to former wiki page (i.e. "2" of Mar 2010) still highlighted as if page exists
   2. link to renamed wiki page (i.e. "3" of Mar 2010) is not highlighted as if page not exists
9. access relevant wiki pages through link provided by WikiTicketCalendarMacro calender, see:
   1. link to former wiki page (i.e. "2") - page missing, getting offer to create it
   2. link to renamed wiki page (i.e. "3") which has "?action=edit" appended - page exists, so getting offer to save v2 (!)

conclusion:

WikiTicketCalendarMacro does rely on cached wiki page, but WikiRenamePlugin doesn't give appropriate notice of effective page name changes (to CacheManager (used by WikiSystem), approved/details found by code studies)

[Steffen Hoffmann]

solution found by studying CacheManager, syntax of cache invalidation found in

​http://svn.edgewall.com/repos/trac/trunk/trac/wiki/model.py

proposed patch for WikiRenamePlugin:

--- ./wikirename_trunk-7750/wikirename/util.py	2010-03-03 22:54 +0100
+++ ./wikirename_development/wikirename/util.py	2010-03-03 22:57 +0100
@@ -8,6 +8,7 @@
 
 from trac.core import *
 from trac.env import *
+from trac.wiki.api import WikiSystem
 
 __all__ = ['main', 'rename_page']
 
@@ -87,5 +88,6 @@
 
     if handle_commit:
         db.commit()
-
+        # Invalidate page name cache
+        WikiSystem(env).pages.invalidate(db)

successfully tested here

[Steffen Hoffmann]

unified diff showing how to add required cache invalidation

[Steffen Hoffmann]

updated unified diff (lines 1+2 were mangled, still no display, please load original format)

[Steffen Hoffmann]

second link shows diff in Trac style after importing (almost) the same patch twice - weird

[Ryan J Ollos]

The plugin is deprecated since there is now support in the Trac core.

[Ryan J Ollos]

If you'd like to apply patches I can provide you commit access.

[Steffen Hoffmann]

Sure, since Trac wiki rename feature still needs to be supported in some plugins that this plugin handles for me until now, I would like to apply patches, that I use day-by-day with success.

[Steffen Hoffmann]

(This is an very old ticket of mine before registration here.)

The invalidation can be done even better than I've suggested here to work even for Trac-1.0, so I'll apply an updated version then.

[Ryan J Ollos]

Thank you. I've been trying to close out ticket for projects that are deprecated. I may have gotten a bit overzealous in closing ticket for this one since it is still relevant in Trac 0.11.