Opened 15 years ago
Closed 9 years ago
#6140 closed enhancement (fixed)
add pastebin SearchProvider
| Reported by: | lkraav | Owned by: | ejucovy |
|---|---|---|---|
| Priority: | normal | Component: | TracPastePlugin |
| Severity: | normal | Keywords: | |
| Cc: | ejucovy | Trac Release: | 0.11 |
Description
nuff said.
Attachments (1)
Change History (8)
comment:3 Changed 12 years ago by
| Cc: | ejucovy added; anonymous removed |
|---|
Changed 11 years ago by
| Attachment: | ticket-6140.diff added |
|---|
comment:4 Changed 11 years ago by
Implemented in patch attachment:ticket-6140.diff, which searches the paste's title, content, and mimetype for the provided terms. I'm happy to add tests as well if you think it's worthwhile, but it's a pretty straightforward implementation.
comment:5 follow-up: 7 Changed 11 years ago by
| Owner: | changed from Michael Renzmann to ejucovy |
|---|
Ethan, I granted you w-access to the repository. Feel free to commit the patch.
We may want to:
- Check
PASTE_VIEWpermission, as is done in t:browser:/tags/trac-1.0.1/trac/wiki/web_ui.py?marks=753#L750 - Perform fine-grained permission check on the resource before returning a result, as is done in t:browser:/tags/trac-1.0.1/trac/wiki/web_ui.py?marks=770#L750
I'll do some additional testing after you've committed the change. Thanks for your contribution!
comment:7 Changed 11 years ago by
Replying to rjollos:
Ethan, I granted you w-access to the repository. Feel free to commit the patch.
We may want to:
- Check
PASTE_VIEWpermission, as is done in t:browser:/tags/trac-1.0.1/trac/wiki/web_ui.py?marks=753#L750- Perform fine-grained permission check on the resource before returning a result, as is done in t:browser:/tags/trac-1.0.1/trac/wiki/web_ui.py?marks=770#L750
I'll do some additional testing after you've committed the change. Thanks for your contribution!
Thanks -- good point(s) about the permissions. I've added your suggested permission checks and applied the patch in r13442.
comment:8 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
According to a colleague PasteBin is like a waste bin without this feature. I don't know whether I will find the time to work on this, but I'm interested.