Error: Macro Poll(Test?; a; b) failed

[dev]

I tried PollMacro on my trac installation (current trunk) and tried the example from the wiki page. But I get only this error:

Error: Macro Poll(Test?; a; b) failed

keys

[nextime]

Same here ( trac 0.9.6 )

[Robert Kieffer]

I've figured out the problem. This tracpoll.py code:

        self.votes.update([(k[0], []) for k in self.vote_defs
                           if k[0] not in self.votes])

... is relying on the Python 2.4 implementation of update(). The Python 2.3 version of update() doesn't take an array of tuples as an argument and throws the AttributeError. (This API change is documented in note #9 in ​http://docs.python.org/lib/typesmapping.html)

The solution is to change the above to:

        self.votes.update(dict([(k[0], []) for k in self.vote_defs
                           if k[0] not in self.votes]))

Which only leaves the question of how best to get this change back into the code?

(stacktrace of this bug available in the closed duplicate, #616)

[Alec Thomas]

Thanks for chasing this down. I'll commit the fix over the weekend.

[Alec Thomas]

(In [1155]) Committed fix for Python 2.3, from robert@…. Closes #594.