Opened 15 years ago
Closed 15 years ago
#5758 closed defect (fixed)
When creating a new code review, you cannot assign a user to the review
Reported by: | Owned by: | Sebastian Marek | |
---|---|---|---|
Priority: | highest | Component: | PeerReviewPlugin |
Severity: | blocker | Keywords: | |
Cc: | Ryan J Ollos | Trac Release: | 0.11 |
Description
Where is the users read from in this plaugin
Attachments (0)
Change History (5)
comment:1 Changed 15 years ago by
Cc: | Ryan J Ollos added; anonymous removed |
---|
comment:2 Changed 15 years ago by
I have just installed the plugin and am experiencing this issue.
I am running on trac trunk (0.12) hosted in Apache2.2 with mod_python (2.5) on a Windows Server 2003 machine. I am authenticating users using Active Directory (LDAP).
This problem currently makes the plugin unusable as I am not permitted to create a new review without an assigned user.
Any idea when this will be fixed?
comment:4 Changed 15 years ago by
Same problem to me, but I solved it as follows
trac-admin /path/to/repository permission add target_reviewer CODE_REVIEW_DEV or permission add target_reviewer CODE_REVIEW_MGR
I referred to /peerreviewplugin/0.11/codereview/dbBackend.py
156 def getPossibleUsers(self): 157 cursor = self.db.cursor() 158 cursor.execute("SELECT DISTINCT p1.username as username FROM permission p1 left join permission p2 on p1.action = p2.username WHERE p1.action = 'CODE_REVIEW_DEV' OR p2.action = 'CODE_REVIEW_DEV' OR p1.action = 'CODE_REVIEW_MGR' OR p2.action = 'CODE_REVIEW_MGR'") 159 rows = cursor.fetchall() 160 if not rows: 161 return [] 162 163 users = [] 164 for row in rows: 165 users.append(row[0]) 166 return users
comment:5 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
I got pretty frustrated trying to install this plugin since I could find any installation steps. I think you found an important detail, so I added an installation section to the main page and included your finding, PeerReviewPlugin#Installation. I might take another crack at installing this, but the CodeReviewPlugin looks interesting as well.
rj