[Patch] UnicodeDecode Error line 50 in ticketdeletete_admin.html

[ngolovin@…]

Was solved by changing the line 50 as follows:

<td colspan="3" py:with="ptime=unicode(ticketdelete.
changes[change].prettytime.decode('utf-8'))"><b>Change 
at ${ptime} by ${ticketdelete.changes[change].author}</b></td>

I have german locale setting, that might be the reason why prettytime contains characers that genshi doesn't like.

[anonymous]

I hit this and fixed it by using the locale format "%x %X":

ticketdelete/web_ui.py

@@ -102 +102 @@
                         c_data['author'] = author
                         # FIXME: The datetime handling is not working - enable
                         # for traceback
-                        c_data['prettytime'] = strftime('%a, %d %b %Y %H:%M:%S',time.timetuple())
+                        c_data['prettytime'] = strftime('%x %X',time.timetuple())
                     
                     # Check the boxes next to change number `selected`
                     time_list = list(sorted(ticket_data.iterkeys()))

[gebb@…]

Here is an alternative patch.

ticketdelete/web_ui.py

@@ -8 +8 @@
 from trac.web.api import IRequestFilter
 from trac.web.chrome import ITemplateProvider, add_script, add_stylesheet
 from trac.util import sorted
-from trac.util.datefmt import to_datetime, utc, to_timestamp
+from trac.util.datefmt import to_datetime, utc, to_timestamp, format_datetime
 
 import re
 import traceback
@@ -100 +100 @@
                         c_data = ticket_data.setdefault(to_timestamp(time), {})
                         c_data.setdefault('fields', {})[field] = {'old': oldvalue, 'new': newvalue}
                         c_data['author'] = author
-                        # FIXME: The datetime handling is not working - enable
-                        # for traceback
-                        c_data['prettytime'] = strftime('%a, %d %b %Y %H:%M:%S',time.timetuple())
+                        c_data['prettytime'] = format_datetime(time, '%a, %d %b %Y %H:%M:%S')
                     
                     # Check the boxes next to change number `selected`
                     time_list = list(sorted(ticket_data.iterkeys()))

[Jens Langner]

I run into the same problem with my german python installation. I tried both patches, but the patch with

strftime('%x %X',time.timetuple())

seems more appropriate because the other one still inserts german month names into the web display while the other components of trac are displayed in english. Here I just changed the locale for displaying times like "DD.MM.YYYY" instead of "MM/DD/YYYY". So "%x %X" seems to be more appropriate.

[Matthijs Kooijman]

I've also seen this problem with a french locale. Using the %x %X patch works for me. Any chance to include this?

[Boris Savelev]

comment:3 works for me too (for russian users).

[Ryan J Ollos]

(In [11790]) Fixes #4820: Use trac.util.datefmt.format_datetime from Trac for proper handling of the locale.

[Ryan J Ollos]

If anyone is still using this plugin, I appreciate if you can post feedback on whether [11790] fixed the issue.

[Matthijs Kooijman]

I'm still using this plugin every other day or so to delete spam tickets :-D

I just tried 2.0.1 to find a ticket where the problem occurred and then 2.0.2 / r11790 which fixes the problem for me (french locale).

Thanks!

[Ryan J Ollos]

#8346 closed as a duplicate.

[Ryan J Ollos]

matthijs: Thanks for reporting back. The plugin is no longer needed with Trac 0.12, but I'm trying to wrap up the major issues that affect 0.11 users, since it appears there are still several people using this plugin. If any of the open issues are affecting you, please assign the tickets to me and I'll get them fixed.

[Matthijs Kooijman]

We're still running on 0.11, so ticketdelete is useful for me still. I just looked through the list of tickets, there's nothing that I've ran into on first glance, so everything is pretty functional for me. I think there was some issue with deleting changes (IIRC using the checkmarks on complete changes didn't work or something, but the Delete Change button did), but that doesn't really bother me, so I'm fine!

[Ryan J Ollos]

Thanks for checking. I'll CC you on any other tickets that I make changes against, in case you might have an interest in the fix.