Modify ↓
#4722 closed defect (fixed)
post_process_request not preserve content_type, which cause text/plain templates fail to render.
Reported by: | Jiang Xin | Owned by: | Jiang Xin |
---|---|---|---|
Priority: | highest | Component: | TracCoSignPlugin |
Severity: | blocker | Keywords: | |
Cc: | Trac Release: | 0.11 |
Description
post_process_request in traccosign/accountldap.py carelessly set content_type to None. It's bad if template is not a html template but a text template.
This bug cause plain text output of source code revision log raise a exception:
Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 459, in _dispatch_request dispatcher.dispatch(req) File "/usr/lib/python2.5/site-packages/trac/web/main.py", line 237, in dispatch content_type) File "/usr/lib/python2.5/site-packages/trac/web/chrome.py", line 740, in render_template template = self.load_template(filename, method=method) File "/usr/lib/python2.5/site-packages/trac/web/chrome.py", line 724, in load_template return self.templates.load(filename, cls=cls) File "/var/lib/python-support/python2.5/genshi/template/loader.py", line 227, in load filename, encoding=encoding) File "/var/lib/python-support/python2.5/genshi/template/loader.py", line 265, in _instantiate allow_exec=self.allow_exec) File "/var/lib/python-support/python2.5/genshi/template/markup.py", line 67, in __init__ allow_exec=allow_exec) File "/var/lib/python-support/python2.5/genshi/template/base.py", line 406, in __init__ raise TemplateSyntaxError(e.msg, self.filepath, e.lineno, e.offset) TemplateSyntaxError: not well-formed (invalid token): line 1, column 1 (/usr/lib/python2.5/site-packages/trac/versioncontrol/templates/revisionlog.txt, line 1)
Attachments (0)
Note: See
TracTickets for help on using
tickets.
(In [5325]) Fixed #4722: wrong content_type return value from post_process_request.