Modify ↓
#3591 closed enhancement (fixed)
Include macro doesn't work with relative wiki links
Reported by: | Jim Sermersheim | Owned by: | Steffen Hoffmann |
---|---|---|---|
Priority: | normal | Component: | IncludeMacro |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 0.11 |
Description (last modified by )
From a wiki page called "Parent":
This works:
[[Include(Parent/Child)]]
This doesn't work:
[[Include(Child)]]
Attachments (2)
Change History (14)
comment:2 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 11 years ago by
Owner: | changed from Noah Kantrowitz to Ryan J Ollos |
---|---|
Status: | new → assigned |
comment:4 Changed 10 years ago by
Changed 10 years ago by
Attachment: | 20140828_resolve-relative-wiki-links.patch added |
---|
proposed patch for adding relative wiki page resolution for wiki page includes
comment:5 Changed 10 years ago by
Note: I've shortened the code by using existing _split_path
function to extract optional wiki page version too, what is unrelated to the solution.
Changed 10 years ago by
Attachment: | 20140828_includemacro_pep8.patch added |
---|
some PEP8 and nit-picking on doc-string and comment style
comment:6 Changed 10 years ago by
The second patch just proposes some code clean-up, especially shortening line length in multiple places. Apply at as you like.
comment:7 Changed 10 years ago by
Thanks for the patches. Feel free to push your changes and I'll do a retrospective review when I have some time.
comment:10 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Changes work well. Thanks!
comment:11 Changed 9 years ago by
Owner: | changed from Ryan J Ollos to Steffen Hoffmann |
---|
comment:12 Changed 9 years ago by
Type: | defect → enhancement |
---|
Note: See
TracTickets for help on using
tickets.
This has been requested on the mailing list again recently.
Btw, the example in the description is bogus, because scoped wiki link resolution in Trac core searches siblings of the current page, and then looks upwards on the path, never downwards, as suggested.