[PATCH] Create New Wiki Page with a Tag

[Catalin BALAN]

test:

• create new Page
• enter text
• add a tag
• Submit Changes
• all text is lost!

Attached patch fixes this.

[Alec Thomas]

(In [3808]) Fix for creation of new pages with tags. Thanks to Catalin Balin. Closes #3145.

[anonymous]

Not for me. Running TracTags 0.6dev-r3882 trunk I have the same problem with editing existing pages which already have tags. You can 1. either change tags or change text, but not both at the same time. Changing tags changes the tags and does not change texts and vice versa. Trac 0.11 with sqlite and py25

[martin@…]

I believe this is a reincarnation of #3206. For me, the latest drunk does not work with the symptoms of #3206. But this does work and does not have any problems. It also adds svn revision to the egg version as I run from trunk:

Index: tractags/wiki.py
===================================================================
--- tractags/wiki.py	(revision 3905)
+++ tractags/wiki.py	(working copy)
@@ -70,12 +70,6 @@
             # Always save tags if the page has been otherwise modified
             if page_modified:
                 self._update_tags(req, page)
-            elif page.version > 0:
-                # If the page hasn't been otherwise modified, save the tags
-                # and redirect so we don't get the "page has not been modified"
-                # warning
-                if self._update_tags(req, page):
-                    req.redirect(get_resource_url(self.env, page.resource, req.href, version=None))
         return []
 
     # IWikiChangeListener methods
Index: setup.cfg
===================================================================
--- setup.cfg	(revision 0)
+++ setup.cfg	(revision 0)
@@ -0,0 +1,3 @@
+[egg_info]
+tag_build = dev
+tag_svn_revision = true

[Alec Thomas]

This should be fixed in r3877.