Plugin Misnamed?

[anonymous]

I'm sure this is debatable, but wouldn't this plugin be more appropriately called something like "ADSSessionSettingsPatch"? If it can only talk to AD, and requires windows extensions to python, then it's not really an LDAP plugin at all, it's an ADS plugin. Sorry if this sounds like splitting hairs, but I found the name to be a bit misleading.

[Morris]

I don't disagree with you: the name is misleading. The reason it's named that is that I set out to make the plugin truly LDAP, not AD-specific. However, I ran out of time and needed it to Just Work: AD was the employer-mandated use case that had to work, so that's all this plugin ended up being :/

Making another pass at it to make it non-AD specific is on my list of to-dos, but it will be some time before I get to it. In the meantime, if you're feeling motivated patches are more than welcome ;)