Modify

Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#1991 closed defect (fixed)

[PATCH] use the correct url for Tags menu.

Reported by: Bhuricha Deen Sethanandha Owned by: Alec Thomas
Priority: normal Component: TagsPlugin
Severity: normal Keywords:
Cc: Trac Release: 0.11

Description

I used TagsPlugins with the Trac 0.11dev and the Tags Menus doesn't have the correct URL. In Trac 0.11 req.href should be used to get the correct URL.

I am trying to fix the api.py with the same solution but the object doesn't have reference to the req object. I think you might know how to do it.

Attachments (1)

web_ui.diff (776 bytes) - added by Bhuricha Deen Sethanandha 17 years ago.

Download all attachments as: .zip

Change History (6)

Changed 17 years ago by Bhuricha Deen Sethanandha

Attachment: web_ui.diff added

comment:1 Changed 17 years ago by cobwebsmasher

You may want to verify that you are using the correct version of TracTags. The plugin itself was not rated for 0.11 until very recently, AFAIK, the "latest" version can be tracked down if you check the google group (old usenet/deja news): trac-users. I had the same problem, and while your hack/fix might be valid, there were other changes due to the architecture change in Trac that might make your fix just the tip of the iceberg as far as tags are concerned.

comment:2 Changed 17 years ago by Alec Thomas

Try setting base_url in the [trac] section of your TracIni file. Without a request object, Trac relies on this setting to reconstruct URLs, so you'll need it anyway.

comment:3 Changed 17 years ago by cobwebsmasher

Hey Alec, I read somewhere that the 0.9 version of TracTags couldn't do anything about the Tags link showing whether or not the user was authenticated. Is that still the case for your 0.11 branch?

comment:4 Changed 17 years ago by Alec Thomas

Resolution: fixed
Status: newclosed

Good point. Check out r2608, I've added some permissions as well as using req.href where I can.

comment:5 Changed 17 years ago by Bhuricha Deen Sethanandha

Thank Alec for fixing this. I knew that my patch might not be sufficient but I tried to point to the code that need to be changed. Hopefully, I will be able to point what under the surface as I gain more insight to Trac. Thanks again.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Alec Thomas.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.