Plugin conflicting with trac-spamfilter plugin

[Oleksij]

First of all, thank you for your MarkDown macro plugin - I found it very useful. However, I found one small issue. I do have spam filter plugin installed and when i am clicking on Monitoring in admin menu (/admin/spamfilter/monitor URL) i am getting error:

Trac detected an internal error:

AttributeError: 'int' object has no attribute 'name'

And python traceback points to the macro:

Python Traceback
Most recent call last:

    File "/usr/local/lib/python3.9/site-packages/trac/web/main.py", line 609 , in dispatch_request
    File "/usr/local/lib/python3.9/site-packages/trac/web/main.py", line 301 , in dispatch
    File "/usr/local/lib/python3.9/site-packages/trac/web/main.py", line 250 , in dispatch
    File "/usr/local/lib/python3.9/site-packages/trac/web/main.py", line 469 , in _post_process_request
    File "/usr/local/lib/python3.9/site-packages/tracmarkdown/macro.py", line 153 , in post_process_request 

Not sure why only that page is impacted, however, i was able to fix it with that patch:

tracmarkdown/macro.py

@@ -148 +148 @@
         def wiki_to_html(self, context, wikidom, escape_newlines=None):
             return Markup(format_to_markdown(self, context, wikidom))
 
-        if template and data and 'page' in data:
+        if template and data and 'page' in data and hasattr(data, 'name'):
             # We only handle wiki pages
             path = data['page'].name.split('/')
             if path[0] in self.root_pages:

I am using Trac 1.6, trac-macro is r18423, and spamfilter is r17763

[Jun Omae]

I think the patch stops markdown formatting on wiki pages (data variable is a dict instance and doesn't have name attribute).

Instead, try the following patch:

markdownmacro/trunk/tracmarkdown/macro.py

@@ -45 +45 @@
 from trac.web.api import IRequestFilter, IRequestHandler
 from trac.web.chrome import add_stylesheet, ITemplateProvider, add_warning, web_context
 from trac.wiki.api import WikiSystem
+from trac.wiki.model import WikiPage
 from trac.wiki.formatter import format_to_html, format_to_oneliner, Formatter, system_message
 from trac.wiki.macros import WikiMacroBase
 
@@ -148 +149 @@
         def wiki_to_html(self, context, wikidom, escape_newlines=None):
             return Markup(format_to_markdown(self, context, wikidom))
 
-        if template and data and 'page' in data:
+        if template and data and isinstance(data.get('page'), WikiPage):
             # We only handle wiki pages
             path = data['page'].name.split('/')
             if path[0] in self.root_pages: