Modify ↓

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#14005 closed defect (fixed)

Make plugin compatible with Trac 1.6

Reported by: Cinc-th Owned by: Cinc-th
Priority: normal Component: PeerReviewPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

With #13972, #13584 and #13980 the plugin was enabled for Trac 1.0/1.2/1.4.

Currently it doesn't work with Trac 1.6 and Python 3 so some fixes are necessary.

Attachments (0)

Change History (7)

comment:1 Changed 4 years ago by Cinc-th

In 18249:

PeerReviewPlugin: fix imports and create cmp() function for Python 3.

Refs #14005

comment:2 Changed 4 years ago by Cinc-th

In 18250:

PeerReviewPlugin: fix more imports.

Refs #14005

comment:3 Changed 4 years ago by Cinc-th

In 18251:

PeerReviewPlugin: fixes for sort() and iteritems().

Refs #14005

comment:4 Changed 4 years ago by Cinc-th

In 18252:

PeerReviewPlugin: replace dict.iteritems() in templates. Replace method has_key(). Replace unocode() with to_unicode. Fix sorting of dict keys.

Refs #14005

comment:5 Changed 4 years ago by Cinc-th

In 18257:

PeerReviewPlugin: on the changeset page some Genshi template rendering was still used.

Refs #14005, #13972, #13980

comment:6 Changed 4 years ago by Cinc-th

Resolution: → fixed
Status: new → closed

Current testing indicates that the plugin is now working with Trac 1.6 and Python 3.

comment:7 Changed 4 years ago by Cinc-th

In 18261:

PeerReviewPlugin: no longer use CamelCase URLs. Fixed a testcase using unicode strings for Python3.

Refs #14005

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Cinc-th.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.