Modify

Opened 4 years ago

Closed 4 years ago

#13961 closed defect (fixed)

Incompatibility with Trac 1.4.2

Reported by: Ian.Goodacre@… Owned by: Ryan J Ollos
Priority: normal Component: MarkdownMacro
Severity: normal Keywords:
Cc: Trac Release: 1.4

Description (last modified by Ryan J Ollos)

I recently installed Trac 1.4.2 and MarkdownMacro from https://trac-hacks.org/browser/markdownmacro?rev=18008&format=zip but MarkdownMacro didn't work. I traced the failures to two issues with the plugin installed to plugins of my project:

1) The installation instructions refer to component tracmarkdown.macro.markdowneverywhere, but that did nothing for me. What worked for me was tracmarkdown.macro.markdownformatter. With the latter I was able to disable processing of markdown everywhere, leaving just the macro processor.

2) Processing markdown everywhere failed, resulting in blank pages, when markdown processing everywhere was enabled. I traced this to the tab_length argument to the markdown function. It was u'4', which was an incompatible type. Changing it to 4 worked and changing the call to set tab_length in format_to_markdown from env.config.get to env.config.getint returned 4 instead of u'4', which also worked.

I was working with a fresh install of Python 2.7.18 installed by asdf, in case that makes a difference, though it appears that env.config is Trac code and the get method of the Configuration class appears to be documented to return a string, though I don't know the code well and might be misunderstanding.

Attachments (0)

Change History (5)

comment:1 Changed 4 years ago by Jun Omae

Component: SELECT A HACKMarkdownMacro
Trac Release: 1.4

comment:2 Changed 4 years ago by Ryan J Ollos

Owner: set to Ryan J Ollos
Status: newaccepted

comment:3 Changed 4 years ago by Ryan J Ollos

Description: modified (diff)
  1. See revisions in MarkdownMacro@29.
  2. Good find. I will fix that.

comment:4 Changed 4 years ago by Ryan J Ollos

In 18014:

TracMarkdownMacro 0.11.9dev: Fix incorrect type for option

Refs #13961.

comment:5 Changed 4 years ago by Ryan J Ollos

Resolution: fixed
Status: acceptedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.