Import 'ngettext' is missed

[Andrew G. Khodotov]

When I set "clear_fields" operation, I get "NameError: global name 'ngettext' is not defined" error. Quote from trace log:

  File "/home/and/.local/lib/python2.7/site-packages/advancedworkflow/controller.py", line 269, in render_ticket_action_control
    hint = ngettext("The %(fields)s field will be cleared.",

Need to append import section:

from trac.util.translation import domain_functions, ngettext

has solve.

[Jun Omae]

The use of ngettext is introduced in r16901 (#13237).

We should use ngettext from domain_functions() rather than importing from trac.util.translation.

advancedworkflow/controller.py

@@ -29 +29 @@
 from trac.web.chrome import Chrome, add_warning
 
 
-_, tag_, add_domain = domain_functions('advancedworkflow',
-                                       '_', 'tag_', 'add_domain')
+_, tag_, ngettext, add_domain = \
+    domain_functions('advancedworkflow', '_', 'tag_', 'ngettext', 'add_domain')
 
 
 class TicketWorkflowOpBase(Component):

[Andrew G. Khodotov]

Well, so be it. Please apply this patch to version in repository. 1.2.2.dev0 from https://trac-hacks.org/svn/advancedticketworkflowplugin/1.2/ has a bug.

[Ryan J Ollos]

In 17954:

TracAdvancedTicketWorkflow 1.2.2dev: Add missing import

Patch by Jun Omae.

Fixes #13939.