Support Trac 1.4

[anonymous]

I don't have time to take on maintenance of this plugin or indeed an in-depth knowledge of the finer points of trac plugin implementation.. but needed to get this plugin not to bring down the entire Trac UI when enabled.

Version available here that allows upgrade to work. It appears to work for our use case. YMMV. ​https://github.com/petebannister/breadcrumbsnavplugin

[Ryan J Ollos]

This plugin wants to force an Environment upgrade every time the Environment is reloaded when there are breadcrumbs in the session_attributes table. However, the logic in Environment upgrade is wrong because of the misnamed attribute breadcrumbs list -> breadcrumbs_list.

I'm going to change the logic to clear the table without requiring that an Environment upgrade be manually executed.

[Ryan J Ollos]

In 17865:

TracBreadCrumbsNav 0.4dev: Make compatible with Trac 1.4+

Fix logic that clears the session_attribute table on
environment reload.

Initial patch by petebannister.

Fixes #13885.

[Ryan J Ollos]

I changed the plugin name, so you'll need to uninstall the old:

$ pip uninstall BreadCrumbsNav
$ pip install svn+https://trac-hacks.org/svn/breadcrumbsnavplugin/trunk

[clemens]

Replying to Ryan J Ollos:

In 17865: compatible with Trac 1.4+

Hello Ryan

I tested most recent BreadCrumbsNavPlugin 0.4 [17865] with Trac 1.4.2 but could not get it running.

Following error:

2021-01-01 00:45:20,190 Trac[env] INFO: -------------------------------- environment startup [Trac 1.4.2] --------------------------------
2021-01-01 00:45:20,273 Trac[loader] ERROR: Skipping "breadcrumbsnav = breadcrumbsnav.breadcrumbs": ImportError: No module named genshi.filters.transform

I am wondering about breadcrumbs.py​ referencing genshi.filters.transform. As far as I know Genshi is not supported with Trac 1.4 anymore.

Clemens

[Ryan J Ollos]

In 17945:

TracBreadCrumbsNav 0.4dev: Require Genshi

Refs #13885.

[Ryan J Ollos]

It should work, just checked with Trac 1.4, but you need Genshi installed.

Genshi is still supported in Trac 1.4, but doesn't work in all cases.

[clemens]

Replying to Ryan J Ollos:

It should work, just checked with Trac 1.4, but you need Genshi installed.

OK! I uninstalled the old and installed your new revision [17945] which states dependency to Genshi. I did not have Genshi on my Trac 1.4 test machine. Thanks to your change PIP now automatically installed Genshi. Everything fine now!

Thanks.