Support formulas like ExportImportXlsPlugin does

[dries.decock@…]

We have would like to import an excel document based on a template we have. To do this, we added an additional tab containing all the information we want to import into trac. With the ExportImportXlsPlugin, the values are imported. But the TicketImportPlugin doesn't evaluate the formula but imports the formula.

[Jun Omae]

Could you please try the following patch?

talm_importer/readers.py

@@ -172 +172 @@
     def __init__(self, filename, sheet_index, datetime_format):
         self.fileobj = open(filename, 'rb')
         self.book = openpyxl.load_workbook(filename=self.fileobj,
-                                           read_only=True)
+                                           read_only=True, data_only=True)
         worksheets = self.book.worksheets
         self.sheets_count = len(worksheets)
         self.sheet = worksheets[sheet_index - 1]

[dries.decock@…]

Perfect! That does the trick.

The only minor issue I still have is that formulas which produce an empty line will generate empty tickets.

Thanks!

[Jun Omae]

Also, neither xlrd nor openpyxl can evaluate formula in Excel file. The stored value at last modified are returned.

See ​https://bitbucket.org/openpyxl/openpyxl/src/2.4.1/openpyxl/reader/excel.py?at=default&fileviewer=file-view-default#excel.py-138.

[Jun Omae]

In 16997:

TicketImportPlugin: use a stored value for formula when openpyxl is used (closes #13337)