Can't open an XLSX file.

[roger.oberholtzer@…]

When I try to open an Excel sheet in Trac 1.2.2 with the current version of the plugin, I get this error:

Warning: HTML preview using ExcelXSLTRenderer failed (AttributeError: 'Worksheet' object has no attribute 'get_highest_row') 

Is there a minimum version of Excel for which this works?

[Jun Omae]

It seems get_highest_row method has been removed in openpyxl 2.4. See ​https://bitbucket.org/openpyxl/openpyxl/commits/39ce87a92a1ed4e48e452676248e479fc276c56c#chg-openpyxl/worksheet/worksheet.py.

However, return value of the sheet.get_highest_row() is not used. We could remove the line...?

excelxlstviewerplugin/0.11/tracexcelxlstviewer/__init__.py

@@ -49 +49 @@
             continue # Skip empty sheet
         buf.append(u'<table class="listing"><caption>%s</caption>\n' % escape(sheetName))
             buf.append(u'<tbody>')
-        sheet.get_highest_row()
         rowIdx = 0
         for row in sheet.range(sheet.calculate_dimension()):
                 buf.append(u'<tr class="%s">' % (rowIdx % 2 and 'odd' or 'even'))

[Ryan J Ollos]

In 16798:

TracExcelXLSTViewer 0.9.3: Fix mixed tabs and spaces

Refs #13269.

[Ryan J Ollos]

In 16799:

TracExcelXlstViewer 1.0dev: Make compatible with Trac 1.0+ and newer openpyxl

Be sure to uninstall the old plugin before installing this
version, as the entry point has been changed.

Fixes #13269.

[roger.oberholtzer@…]

Replying to Ryan J Ollos:

Be sure to uninstall the old plugin before installing this version, as the entry point has been changed.

Hmmm. All this time I have been using Trac, and I have never uninstalled a plugin. I installed it via the setup.py in the plugin. How to uninstall? (I feel rather stupid asking!)

BTW, I do not use pip or easy_install because on openSUSE there seems to be an issue. I run Python 2.7 (to make Trac happy), but these at some point get confused and want to do some Python 3 stuff. So I use the plugin's setup.py to do the installs.

[Ryan J Ollos]

See ​trac:TracPlugins#Uninstalling.