Modify ↓

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13130 closed defect (fixed)

r16376 broke compatibility with trac v1.01

Reported by: christiano@… Owned by: Ryan J Ollos
Priority: normal Component: CiteCodeMacro
Severity: normal Keywords:
Cc: Trac Release: 1.0

Description

From the trac log file

File "build/bdist.linux-x86_64/egg/traccitecode/citecode.py", line 137, in <module> ImportError: cannot import name tag

Attachments (0)

Change History (4)

comment:1 Changed 8 years ago by Ryan J Ollos

Owner: changed from tkob-trac to Ryan J Ollos
Status: new → accepted
Summary: Rev# 16376 broke compatability with trac v1.01 → r16376 broke compatibility with trac v1.01

comment:2 Changed 8 years ago by tkob-trac

The changeset contains change from genshi.builder.tag to trac.util.html.tag (because newer version of Trac is dropping genshi?) and it looks like Trac 1.0 does not have the latter.

However, since LineNumberAnnotator, which uses tag, is created for compatibility reason, as the comment says, I think it makes sense to stick to genshi here.

'1.2 branch' would be able to drop LineNumberAnnotator.

@rjollos Any thoughts?

comment:3 Changed 8 years ago by Ryan J Ollos

Resolution: → fixed
Status: accepted → closed

In 16417:

TracCiteCode 0.3.3: Restore compatibility with Trac < 1.0.2

Fixes #13130.

comment:4 Changed 8 years ago by Ryan J Ollos

I made an error in r16376. The best practice for forward compatibility is to use ​html, which is basically the same as genshi.builder.tag, but also compatible with future versions of Trac that switch to Jinja2.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Ryan J Ollos.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.