#13067 closed defect (fixed)
Don't autocomplete if phrase starts with backtick
Reported by: | Ryan J Ollos | Owned by: | Peter Suter |
---|---|---|---|
Priority: | normal | Component: | WikiAutoCompletePlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: |
Description
In #12118 I was typing:
Please post your [ticket-workflow]
section.
After typing `[
the auto-complete appears, but probably shouldn't for this case.
Attachments (2)
Change History (11)
Changed 8 years ago by
Attachment: | Screen Shot 2017-02-11 at 22.54.51.png added |
---|
comment:1 follow-up: 2 Changed 8 years ago by
comment:2 Changed 8 years ago by
Replying to psuter:
Would you also prevent other cases like
`wiki:
?
Yeah, looks good.
Or not prevent auto-completions after closing backquote like
`quoted`[
? I don't see an obvious need.
I agree that it's probably not needed.
comment:3 follow-up: 8 Changed 8 years ago by
Also, not sure if this is practical, but it would be nice to avoid auto-completing with local resources when typing an InterTrac prefix, e.g. trac:#
, t:wiki:
.
Changed 8 years ago by
Attachment: | T13067_context_remove_quoted.diff added |
---|
comment:4 Changed 8 years ago by
A better approach might be to use a context function that removes `quoted`
strings and {{{ ... }}}
blocks before attempting to match.
Only the {{{#!...
preprocessor completions should not use that. Unfortunately there seems to be a bug in jquery-textcomplete, but it might be possible to workaround it by handling the preprocessors first.
comment:6 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:8 follow-up: 9 Changed 8 years ago by
Replying to Ryan J Ollos:
Also, not sure if this is practical, but it would be nice to avoid auto-completing with local resources when typing an InterTrac prefix, e.g.
trac:#
,t:wiki:
.
Do you have any thoughts about this one? Should I create a different ticket?
I think we could prevent auto-completions after
`[
like this:wikiautocomplete/htdocs/js/wikiautocomplete.js
])\[(\w*)$/,Would you also prevent other cases like
`wiki:
? Or not prevent auto-completions after closing backquote like`quoted`[
? I don't see an obvious need.I think ideally we would also prevent auto-completions inside
{{{
/}}}
, but it's not obvious to me how to best achieve this.