Modify ↓

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#12981 closed defect (fixed)

Make compatible with Trac 1.2

Reported by: Jun Omae Owned by: Jun Omae
Priority: normal Component: AutocompleteUsersPlugin
Severity: normal Keywords:
Cc: Ryan J Ollos, Jun Omae Trac Release: 1.2

Description

Removed Environment.get_db_cnx is used in the plugin. We could replace it with get_read_db because Supporting Trac 0.11 has been dropped.

Attachments (1)

t12981.diff​ (6.8 KB) - added by Jun Omae 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Jun Omae

Attachment: t12981.diff​ added

comment:1 Changed 8 years ago by Jun Omae

Proposed changes with unit tests: t12981.diff​.

comment:2 Changed 8 years ago by Ryan J Ollos

Changes look good to me.

comment:3 Changed 8 years ago by Jun Omae

Resolution: → fixed
Status: new → closed

In 16060:

0.4.4dev: make compatible with Trac 1.2 and add unit tests (closes #12981)

comment:4 Changed 8 years ago by Jun Omae

Owner: changed from Tetsuya Morimoto to Jun Omae

comment:5 Changed 8 years ago by Ryan J Ollos

Regarding AutocompleteUsersPlugin@46, when the plugin is stable we can publish the new version, presumably 0.4.4, to PyPI.

Oh, I see you are both package owners for TracAutocompleteUsersPlugin on PyPI, so I guess that was probably the intention with AutocompleteUsersPlugin@46.

Last edited 8 years ago by Ryan J Ollos (previous) (diff)

comment:6 Changed 7 years ago by Ryan J Ollos

In 17201:

TracAutocompleteUsersPlugin 0.4.5dev: Remove obsolete code

The compatibility code is not needed after r16060.

Refs #12981.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.