Release AccountManager 0.5

[Ryan J Ollos]

This ticket will track the 0.5 release of AccountManagerPlugin.

[Ryan J Ollos]

The following tickets can be resolved in the release, per my review: #12534, #12058, #12054, #12050, #12024, #11991, #11879, #11867, #11798, #11469, #11312, #11215, #11213, #11111, #11090, #11038, #10945, #10829, #10772, #10754, #10745, #10742, #10741, #10740, #10739, #10684, #10682, #10680, #9946, #8930, #8796, #8595, #8217, #7426, #6788,

Before the release I'll also resolve the following tickets: #12228, #12192, #11915, #11869, #11622, #11545, #10743,

Please let me know if I'm mistaken about the status of any of these tickets. I went through them very quickly. It would take me at least an entire day to read through all the tickets. I don't have time for that in the near future and I feel it's important to push out a release, even if it's not perfect.

[Ryan J Ollos]

AccountManagerPlugin 0.5 will be compatible with Trac 1.0 and later (comment:3:ticket:12722).

[anonymous]

Trac 1.2 was released back in November. Any chance of a compatible release soonish?

[Ryan J Ollos]

The current trunk works with Trac 1.2. You can install directly from the trunk if you need Trac 1.2 support. There are some open issues you may want to review to see if they'll affect your installation.

[Paul Howarth]

Test suite in trunk doesn't seem to run at all:

cd TracAccountManager-0.5dev-r16056
+ /usr/bin/python2 setup.py test
running test
running egg_info
writing requirements to TracAccountManager.egg-info/requires.txt
writing TracAccountManager.egg-info/PKG-INFO
writing top-level names to TracAccountManager.egg-info/top_level.txt
writing dependency_links to TracAccountManager.egg-info/dependency_links.txt
writing entry points to TracAccountManager.egg-info/entry_points.txt
reading manifest file 'TracAccountManager.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files found matching 'contrib/signatures.py'
writing manifest file 'TracAccountManager.egg-info/SOURCES.txt'
running build_ext
Traceback (most recent call last):
  File "setup.py", line 103, in <module>
    **extra
  File "/usr/lib64/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/lib64/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/lib64/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/usr/lib/python2.7/site-packages/setuptools/command/test.py", line 211, in run
    self.run_tests()
  File "/usr/lib/python2.7/site-packages/setuptools/command/test.py", line 234, in run_tests
    **exit_kwarg
  File "/usr/lib64/python2.7/unittest/main.py", line 94, in __init__
    self.parseArgs(argv)
  File "/usr/lib64/python2.7/unittest/main.py", line 149, in parseArgs
    self.createTests()
  File "/usr/lib64/python2.7/unittest/main.py", line 158, in createTests
    self.module)
  File "/usr/lib64/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib64/python2.7/unittest/loader.py", line 100, in loadTestsFromName
    parent, obj = obj, getattr(obj, part)
AttributeError: 'module' object has no attribute 'tests'

Is that normal or am I missing something? I expected a few test failures but not for the whole suite not to run.

[Ryan J Ollos]

Replying to Paul Howarth:

Is that normal or am I missing something? I expected a few test failures but not for the whole suite not to run.

It works fine for me, no test failures. See accountmanager_session_log​.

Invoking the module directly will sometimes reveal import or syntax errors:

$ python setup.py develop
$ python acct_mgr/tests/__init__.py

[Paul Howarth]

Ah, got it. I'm trying to do downstream packaging of the plugin, and my first step was to create a "release tarball" using "python setup.py sdist". When I did that, the directory structure I got didn't include the tests, which was because of this line in setup.py:

packages = find_packages(exclude=['*.tests*']),

If I edited that to:

packages = find_packages(),

then the tests were included in the tarball and I was able to run them successfully.

[nomoo]

guys, rjollos, is current accountmanager compatible with trac 1.2? I'm getting this error:

AttributeError: 'Environment' object has no attribute 'get_db_cnx'

stacktrace:

File "/usr/local/lib/python2.7/site-packages/trac/web/main.py", line 623, in _dispatch_request
  dispatcher.dispatch(req)
File "/usr/local/lib/python2.7/site-packages/trac/web/main.py", line 239, in dispatch
  resp = chosen_handler.process_request(req)
File "/usr/local/lib/python2.7/site-packages/trac/admin/web_ui.py", line 108, in process_request
  provider.render_admin_panel(req, cat_id, panel_id, path_info)
File "/usr/local/lib/python2.7/site-packages/acct_mgr/admin.py", line 216, in render_admin_panel
  return self._do_users(req)
File "/usr/local/lib/python2.7/site-packages/acct_mgr/admin.py", line 523, in _do_users
  data['accounts'] = fetch_user_data(env, req, filters)
File "/usr/local/lib/python2.7/site-packages/acct_mgr/admin.py", line 50, in fetch_user_data
  if guard.user_locked(username):
File "/usr/local/lib/python2.7/site-packages/acct_mgr/guard.py", line 214, in user_locked
  not user_known(self.env, user):
File "/usr/local/lib/python2.7/site-packages/acct_mgr/model.py", line 75, in user_known
  db = _get_db(env, db)
File "/usr/local/lib/python2.7/site-packages/acct_mgr/model.py", line 292, in _get_db
  return db or env.get_db_cnx()

modules:

AutocompleteUsers 	0.4.1 	 	/usr/local/lib/python2.7/site-packages
TracAccountManager 	0.5dev-r0 	/usr/local/lib/python2.7/site-packages

Should i open a new ticket?

[Ryan J Ollos]

HEAD of trunk is compatible with Trac 1.2.x. Your stacktrace is not consistent with running the r16562 of the trunk.

[nomoo]

Replying to Ryan J Ollos:

HEAD of trunk is compatible with Trac 1.2.x. Your stacktrace is not consistent with running the r16562 of the trunk.

Thanks, r16562 working fine.

[Ryan J Ollos]

In 17162:

TracAccountManager: Release 0.5.0

The release has been published to PyPI.

Bump trunk to 0.5.1dev.

Fixes #12569.