[PATCH] Broken link when viewing milestone page if version name contains spaces

[Cinc-th]

When viewing a milestone page the version information is added to the due/completed date line as can be seen here:

The link points to the page for that particular version.

With version names containing spaces the link is broken because only the first word of the version name is used to specify the link target. The following patch resolves the issue:

trunk/extendedversion/milestone.py

@@ -119 +119 @@
             context = Context.from_request(req,
                                            Resource('milestone', milestone))
             return tag.span(
-                "; ",
                 format_to_oneliner(self.env, context,
-                                   "For version:%s" % (row[0],)),
+                                   "; For [version:'%s' %s]" % (row[0], row[0])),
                 class_="date")
         else:
             return []

[Cinc-th]

Patch to allow links to versions with spaces in name.

[Jun Omae]

I think we should directly create a link for the version rather than uses of format_to_oneline. The format_to_* methods are slow.

Untested patch:

extendedversionplugin/trunk/extendedversion/milestone.py

@@ -16 +16 @@
 from trac.util.datefmt import to_timestamp
 from trac.web.api import IRequestFilter, ITemplateStreamFilter
 from trac.web.chrome import INavigationContributor
-from trac.wiki.formatter import format_to_oneliner
+
+from extendedversion.version import VisibleVersion
 
 
 class MilestoneVersion(Component):
@@ -118 +119 @@
         if row:
             context = Context.from_request(req,
                                            Resource('milestone', milestone))
-            return tag.span(
-                "; ",
-                format_to_oneliner(self.env, context,
-                                   "For version:%s" % (row[0],)),
-                class_="date")
+            link = VisibleVersion(self.env)._render_link(context, row[0],
+                                                         row[0])
+            return tag.span("; For ", link, class_="date")
         else:
             return []
 

[Ryan J Ollos]

In 14998:

1.0dev: Properly render version link with whitespace.

Patch by Cinc-th and jun66j5. Fixes #12554.