Modify ↓

Opened 9 years ago

Closed 9 years ago

#12440 closed defect (fixed)

TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'

Reported by: lucid Owned by: lucid
Priority: normal Component: PullRequestsPlugin
Severity: normal Keywords:
Cc: Trac Release:

Description

Creating a PR in the first comment of a ticket doesn't work: 

    File "build/bdist.win32/egg/trac/web/main.py", line 551, in _dispatch_request
    File "build/bdist.win32/egg/trac/web/main.py", line 225, in dispatch
    File "build/bdist.win32/egg/trac/ticket/web_ui.py", line 175, in process_request
    File "build/bdist.win32/egg/trac/ticket/web_ui.py", line 657, in _process_ticket_request
    File "build/bdist.win32/egg/trac/ticket/web_ui.py", line 1364, in _validate_ticket
    File "build/bdist.win32/egg/pullrequests/web_ui.py", line 131, in validate_ticket
    File "build/bdist.win32/egg/pullrequests/web_ui.py", line 152, in _handle_comment
    File "build/bdist.win32/egg/pullrequests/web_ui.py", line 143, in create_pr_and_inline_id

Attachments (0)

Change History (2)

comment:1 Changed 9 years ago by lucid

Apparently Ticket.get_comment_number() returns None (not 0).

comment:2 Changed 9 years ago by lucid

Resolution: → fixed
Status: new → closed

In 14804:

PullRequestsPlugin: Fix bug where PR is created in first comment of a ticket. (ticket.get_comment_number() returns None in that case.)

  • Avoid manipulating PR's during ticket comment preview.
  • Allow any non-whitespace characters in the wikilinks. (especially @ and maybe #?,= should be allowed)
  • Detect author also for logged in users.
  • Bump version to 1.1

(fix #12440)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain lucid.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.