Internal error when ExtendedVersionPlugin is installed

[Cinc-th]

When ExtendedVersionPlugin is installed and the user tries to open the Versions page provided by the plugin the following error is shown:

Trac detected an internal error:

KeyError: 'version'

Traceback:

File ".../Python27/lib/site-packages/trac/web/main.py", line 522, in _dispatch_request
  dispatcher.dispatch(req)
File ".../Python27/lib/site-packages/trac/web/main.py", line 254, in dispatch
  self._post_process_request(req, *resp)
File ".../Python27/lib/site-packages/trac/web/main.py", line 363, in _post_process_request
  resp = f.post_process_request(req, *resp)
File "build/bdist.win32/egg/simplemultiproject/version.py", line 157, in post_process_request
  version = data['version']

[Cinc-th]

In 14608:

Fixed #12371: make sure key 'version' exists in dict before accessing it otherwise skip.

[Cinc-th]

ExtendedVersionPlugin uses the base url /versions for the main version page while SimpleMultiProjectPlugin uses /version (note the missing s) for showing versions from within the roadmap page.

This url checks out true during processing because SimpleMultiProjectPlugin checks by using startswith(). SMP gets data from the other plugin while expecting another set of data thus the error.

By checking for the missing key we make sure the right data is used. This is probably not the perfect solution but works for now.

[Cinc-th]

[14609]: use unique key in dict to mark data as valid for SimpleMultiProjectPlugin. Without key skip processing. Better solution than [14608] because no other plugin will ever add this key.

[falkb]

AFAIK /version is the common URL for versions of a standard Trac system

[falkb]

Replying to Cinc-th:

In 14608:

Fixed #12371: make sure key 'version' exists in dict before accessing it otherwise skip.

Thanks for fixing. Yes, this makes sense. The use of startswith() hits us here... :)