Error occurs when used with MySQL

[theYT <dev@…>]

I am using Trac (version 1.1.5dev) and SQLTable Macro (latest version [14524]) with MySQL Database. When I use macro, 'long' object has no attribute 'fetchall' Error occurs.

It seems to be due to cursor.execute function used in the file table.py / function expand_macro:

• sqlite3.cursor.execute returns cursor
• MySQLdb.cursor.execute returns a number of rows

(​https://www.python.org/dev/peps/pep-0249/#id15 page notes "Return values are not defined.")

Simple patch below have fixed the issue.

wikitable/table.py

@@ -58 +58 @@
         try:
             with self.env.db_query as db:
                 cursor = db.cursor() 
-                rows = cursor.execute(content).fetchall()
+                cursor.execute(content)
+                rows = cursor.fetchall()
                 cols = get_column_names(cursor)
         except self.env.db_exc.DatabaseError, e:
             return system_message(_("Invalid SQL"), exception_to_unicode(e))

[Ryan J Ollos]

Thank you for the patch. I've seen the issue before so I should have known better. I'll commit the change today.

[Ryan J Ollos]

In 14531:

0.3dev: Fix issue fetching from cursor on MySQL.

Patch by theYT <dev@…>. Fixes #12269.