Wrong usage of `pkg_resources.parse_version` in ticketlog/web_ui.py

[Jun Omae]

I found wrong usage of pkg_resources.parse_version in tracticketchangelogplugin/0.12/ticketlog/web_ui.py@14178:60#L57​.

I consider that self.supports_multirepos is always True with any versions of Trac.

>>> from pkg_resources import parse_version
>>> parse_version('0.11.7')
('00000000', '00000011', '00000007', '*final')
>>> parse_version('0.12.5')
('00000000', '00000012', '00000005', '*final')
>>> parse_version('0.11.7') >= (0, 12)
True
>>> parse_version('0.12.5') >= (0, 12)
True
>>> parse_version('1.0.1') >= (0, 12)
True
>>> parse_version('1.1.1') >= (0, 12)
True

I think that we should use parse_version('0.12') rather than (0, 12).

ticketlog/web_ui.py

@@ -57 +57 @@
     def __init__(self):
         locale_dir = resource_filename(__name__, 'locale')
         add_domain(self.env.path, locale_dir)
-        self.supports_multirepos = parse_version(trac.__version__) >= (0, 12)
+        self.supports_multirepos = parse_version(trac.__version__) >= \
+                                   parse_version('0.12')
 
     # IPermissionRequestor methods
 

>>> parse_version('0.11.7') >= parse_version('0.12')
False
>>> parse_version('0.12') >= parse_version('0.12')
True
>>> parse_version('0.12.1') >= parse_version('0.12')
True

[Ryan J Ollos]

That was my error in [13954]. Please feel free to fix the issue.

[Jun Omae]

In 14190:

0.2dev: fixed wrong usage of pkg_resources.parse_version (closes #11997)