[Patch] add filtering by component to ticket statistics

[Miguel Ferreira]

This patch adds a combo box to the template populated with the Components, and filtering by component functionality to the main python file.

This was a useful feature for us.

[anonymous]

patch for component filtering, two files affected

[Ryan J Ollos]

Looks good! I will try to get it applied soon.

[Ryan J Ollos]

I encountered an error on the Ticket Stats page with Trac 1.1.2dev:

Trac detected an internal error:
TypeError: select() takes exactly 2 arguments (3 given)

File "/home/user/Workspace/tracdev/teo-rjollos.git/trac/web/main.py", line 530, in _dispatch_request
  dispatcher.dispatch(req)
File "/home/user/Workspace/tracdev/teo-rjollos.git/trac/web/main.py", line 223, in dispatch
  resp = chosen_handler.process_request(req)
File "/home/user/Workspace/trachacks.git/tracticketstatsplugin/trunk/ticketstats/ticketstats.py", line 163, in process_request
  TicketComponent.select(self.env, show_all)]

The issue is that the second argument to Component.select was db, and it has since been removed: select(cls, env, db=None) -> select(cls, env). This would have had no consequences on Trac 1.0-stable, since the db parameter was deprecated and unused.

Milestone.select has a different signature: select(cls, env, include_completed=True, db=None) (1.0-stable) -> select(cls, env, include_completed=True) (1.2dev).

Also, your patch contained tab characters. You don't want to mix tabs and spaces in Python, and ​spaces are preferred.

No need to refresh the patch. I'll do some more testing later and commit it.

[mpaf98]

Good comments and thanks for having a look, I'll also test it with the new trac next week when back in front of a PC. Sorry for the tabs in the patch..

[Ryan J Ollos]

In 13989:

Add filtering by component. Patch by mpaf98@…. Fixes #11834.