Browsing debug data nodes generates "Can't send unicode data" error with genshi-0.7

[lkraav]

Any other details needed?

Downgrading to 0.6 makes it work again.

See ​trac:#10126

[Olemis Lang]

yes, please ... Trac release ?

[lkraav]

Hmm, trunk but I haven't pulled for a while now.

62b5507 - (origin/trunk, trunk) Merge r11675 from 1.0-stable (#11045) (11 months ago) <cboos>

[lkraav]

This is definitely happening on latest 1.1.2b1 trunk right now.

[lkraav]

I'm running tracd btw.

[lkraav]

Same fix needed as [14006]

[Jun Omae]

I think we should just return template with data from process_request rather than rendering a template in the method. Trac core works well with both Genshi 0.6.x and 0.7.0.

tracdeveloperplugin/trunk/tracdeveloper/debugger.py

@@ -86 +86 @@
         key = token + ':' + path.split(':', 1)[0]
         data = self._cache.get(key)
         if not data:
-            raise HTTPNotFound()
+            raise HTTPNotFound("Not found '%s'" % path)
         node = data.lookup(path)
         data = {'node': node, 'drillable': self._is_drillable(req)}
-        output = Chrome(self.env).render_template(req, 'developer/debug_node.html',
-                                                  data, fragment=True)
-        req.send(output.render('xhtml'), 'text/html')
+        return 'developer/debug_node.html', data, None
 
     # Internal methods
 

[Jun Omae]

Also, I think TemplateDebugger component must check whether a user has TRAC_DEVELOP permission.

tracdeveloperplugin/trunk/tracdeveloper/debugger.py

@@ -28 +28 @@
         return handler
 
     def post_process_request(self, req, template, data, content_type):
-        if 'debug' not in req.args:
+        if 'debug' not in req.args or 'TRAC_DEVELOP' not in req.perm:
             return template, data, content_type
 
         # Purge outdated debug info from cache
@@ -67 +67 @@
     # IRequestHandler methods
 
     def match_request(self, req):
-        match = re.match(r'/developer/debug(?:/(.*))?$', req.path_info)
-        if match:
-            req.args['path'] = match.group(1)
-            return True
+        if 'TRAC_DEVELOP' in req.perm:
+            match = re.match(r'/developer/debug(?:/(.*))?$', req.path_info)
+            if match:
+                req.args['path'] = match.group(1)
+                return True
 
     def process_request(self, req):
         header = req.get_header('X-Requested-With')

[Ryan J Ollos]

In 14628:

TracDeveloper 0.3.0dev: Fix error browsing debugger parameters.

"Can't send unicode data" error was seen with Genshi 0.7. Return template with data rather than rendering template in post_process_request. Fixes #11481.

Patch by Jun Omae.

[Ryan J Ollos]

In 14629:

TracDeveloper 0.3.0dev: Require TRAC_DEVELOP to view debug data.

Patch by Jun Omae. Refs #11481.