Opened 11 years ago
Closed 5 years ago
#11197 closed defect (duplicate)
[PATCH] AutocompleteUsers plugin conflicts with KeywordSuggest plugin
Reported by: | Ben Allen | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | AutocompleteUsersPlugin |
Severity: | normal | Keywords: | |
Cc: | Trac Release: | 1.0 |
Description
The KeywordSuggestPlugin uses the autocomplete API from jQuery, and it uses the jQuery version that is bundled with Trac (for Trac release 1.0 and later). The AutocompleteUsersPlugin includes its own jQuery autocomplete library. When both of these plugins are loaded, the AutocompleteUsersPlugin works but the KeywordSuggestPlugin does not. Presumably, this is because the plugin load order is causing the autocomplete library from the AutocompleteUsersPlugin to override functionality from Trac's jQuery library.
The true solution to this problem is for this plugin to use Trac's jQuery library as well. This is most likely not a trivial task. In the meantime, I have developed a workaround that allows both plugins to coexist peacefully.
The attached patch prefixes all "autocomplete" identifiers in the javascript code with "aup_" (for Autocomplete Users Plugin). This prevents name collisions with Trac's jQuery library, but does not appear to impact the functionality of this plugin.
Attachments (2)
Change History (7)
Changed 11 years ago by
Attachment: | playnice.patch added |
---|
comment:1 Changed 11 years ago by
Status: | new → accepted |
---|
comment:3 Changed 8 years ago by
Hello,
I think I'm facing a similar issue with the TagsPlugin that have the same kind of auto-complete feature for the tag field.
In my case, the auto complete still works for TagsPlugin but not for AutocompleteUsersPlugin. Now when I want to change the 'Cc'ers of a ticket I have no more suggestion contrary to the 'Keywords' field.
I'm gonna look at the fix proposed by AllenB and see if it's still solve this issue.
Changed 8 years ago by
Attachment: | AutocompleteUsersPlugin.diff added |
---|
Fix JQuery issue in using AutocompleteUsersPlugin with TagsPlugin
comment:4 Changed 8 years ago by
autocomplete_perms.js
is missing from my previous fix with the same modification.
comment:5 Changed 5 years ago by
Resolution: | → duplicate |
---|---|
Status: | new → closed |
This will be addressed in #9599.
Workaround