About timeline filter behavior

[anonymous]

In timeline page, there is a "Filter projects" option added by simple multiproject plugin. It only display the selected project's events when a project selected. I got a little confused about the 'ALL' option.I assume the 'ALL' option shouldn't filter out any events, but indeed it filter out changes made to those tickets without its custom field 'project' set.

Here is the way I think 'ALL' option should work

if template == 'timeline.html':
    filter_projects = self._filtered_projects(req)
    if not filter_projects: #no filter means likely more than 1 project, so we insert the project name
-        filter_projects = [project[1] for project in self.__SmpModel.get_all_projects()]
+        return template, data, content_type

[ykrocku@…]

Forget to add my email address

[anonymous]

Wouldn't the patch result in not having the yellow project label anymore, for all the tickets where 'project' is set?

[ykrocku@…]

Replying to anonymous:

Wouldn't the patch result in not having the yellow project label anymore, for all the tickets where 'project' is set?

Yeah, but I think it is better than the way it works now.

[falkb]

In 13291:

bugfix: if "All" is set as timeline filter, display also tickets without a set project (refs #11166)

[falkb]

ykrocku, please test and close this ticket if it's OK now. Thanks a lot for reporting.

[ykrocku@…]

Test ok